From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25901CA0FFF for ; Sat, 30 Aug 2025 16:38:57 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1usOVW-0000yz-Rb; Sat, 30 Aug 2025 12:32:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <3z6SwaAgKCCgFLMPPMIVKSSKPI.GSQUIQY-EVQRSRKRY.SVK@flex--bhillier.bounces.google.com>) id 1urhh6-0008Nd-6x for qemu-arm@nongnu.org; Thu, 28 Aug 2025 14:49:56 -0400 Received: from mail-pl1-x64a.google.com ([2607:f8b0:4864:20::64a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <3z6SwaAgKCCgFLMPPMIVKSSKPI.GSQUIQY-EVQRSRKRY.SVK@flex--bhillier.bounces.google.com>) id 1urhh4-0005W0-Cf for qemu-arm@nongnu.org; Thu, 28 Aug 2025 14:49:56 -0400 Received: by mail-pl1-x64a.google.com with SMTP id d9443c01a7336-248f86a01ceso3534265ad.1 for ; Thu, 28 Aug 2025 11:49:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1756406991; x=1757011791; darn=nongnu.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=eZmDu3jdm85zT/kkoUu6drjP5lcoEw7fmNxr6cvxvOc=; b=xIoPD+cqITqybP+7BMN73F3CzbXoLpDUOhVtvJJb/WhY+dg4DPJvI7+uPfMyVXG0hS n/N8QcPg5LgScGIwxURr3CdDKTmjYLAdwDxAHYeoLB/6zfVJNcrujPBaQZKgpYZhQOjr dh6w1+ZAFP4l/UjSzz0GP2MspTS4YrKGCRhCFYyxgZdUe1ucCgYuW1l2ZQ3uuufAmyp9 Bx09XaKW5EBUzY+qI+BQxG42wHCeUhReMtC6/pcB9XsjaQbsALZWbB8nS91vAriH3QJN D1NM4ItAOmj78V1MxuqIUJO7fdfwYIH+nde/P6wvfbwcOLadWFHYSK1c32ioFhwegJ10 fE1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756406991; x=1757011791; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=eZmDu3jdm85zT/kkoUu6drjP5lcoEw7fmNxr6cvxvOc=; b=IS/z0gQEt7hUi+TBsQlrmBS19k96pYf5NjmFvuz9tH8RVD3NlYhjCCml+L9JyxPsyj Dvx+7DwHPTM00RY9qNC3veskwcc0fszFDUYW62WGfiazHJCW2RFRJlFOWuSqesBI8UbY mC1nHzbE+uvS3B16oeWyA4wP61E0qWqzf7BuE8fMNZoFdhO+/swG7VWz2BottnAx+NpV Zsv/T/HUApC6+j6Qux8rMpW4337jaTWAVky61yZaWceaAzPo4Tjs7nyGE5iwuDVaHI1b hh+WKJSCAI+/6t2EBXWMihjJrwx9tLCEPR2fIy8nvqBpfE4Q4JBpmbqYlHw/WoYTt4QV qWcg== X-Forwarded-Encrypted: i=1; AJvYcCX+O/V9wCEyLaG5h1LE7aY4yRx4Bkv6Ir4/OqEnwHH557IirN1B5wy9IambAvHfi9TvOZYUe7oZkg==@nongnu.org X-Gm-Message-State: AOJu0Yz5wADfQ2M5MJCVExg7A4Wqua393M7h+e7QC8dvfDRjAmp94pUn 8qlbqcHfD2a4IS2gQvj7ZA05XB0FgWp4544Y8d+RKANrtbn95PRAh9/y06F8D2AUK329yNVzbah QAlOaPzz9jLFw7Q== X-Google-Smtp-Source: AGHT+IFFN1RUSe+6N2gyNpYf2PINpcV8AlhKuNHHRTeOId8d2OcXFzH4KBrNVJtnpd8mKrZF9+Ii9+tFlpdVSg== X-Received: from plhy6.prod.google.com ([2002:a17:902:d646:b0:240:11bf:3c68]) (user=bhillier job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:11c7:b0:246:ac9e:6fbe with SMTP id d9443c01a7336-2487539f6aamr133968785ad.10.1756406991128; Thu, 28 Aug 2025 11:49:51 -0700 (PDT) Date: Thu, 28 Aug 2025 18:49:39 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.51.0.318.gd7df087d1a-goog Message-ID: <20250828184939.3140841-1-bhillier@google.com> Subject: [PATCH v2] hw/sensor: add stub for ADM1266 blackbox From: Ben Hillier To: wuhaotsh@google.com, kfting@nuvoton.com Cc: philmd@linaro.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org, Titus Rwantare Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::64a; envelope-from=3z6SwaAgKCCgFLMPPMIVKSSKPI.GSQUIQY-EVQRSRKRY.SVK@flex--bhillier.bounces.google.com; helo=mail-pl1-x64a.google.com X-Spam_score_int: -95 X-Spam_score: -9.6 X-Spam_bar: --------- X-Spam_report: (-9.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org From: Titus Rwantare This patch fixes a bug that causes a kernel panic when calling ADM1266_BLACKBOX_INFORMATION. Log Message: adm1266 5-0042: Could not read blackbox! Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: adm1266_nvmem_read+0x168/0x170 Signed-off-by: Titus Rwantare --- hw/sensor/adm1266.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/hw/sensor/adm1266.c b/hw/sensor/adm1266.c index 9017ce6116..cd11526c2b 100644 --- a/hw/sensor/adm1266.c +++ b/hw/sensor/adm1266.c @@ -75,6 +75,7 @@ typedef struct ADM1266State { static const uint8_t adm1266_ic_device_id[] = {0x03, 0x41, 0x12, 0x66}; static const uint8_t adm1266_ic_device_rev[] = {0x08, 0x01, 0x08, 0x07, 0x0, 0x0, 0x07, 0x41, 0x30}; +static const uint8_t adm1266_blackbox_info[] = {0x04, 0x00, 0x00, 0x00, 0x00}; static void adm1266_exit_reset(Object *obj, ResetType type) { @@ -125,6 +126,17 @@ static uint8_t adm1266_read_byte(PMBusDevice *pmdev) pmbus_send(pmdev, adm1266_ic_device_rev, sizeof(adm1266_ic_device_rev)); break; + case ADM1266_BLACKBOX_CONFIG: + return 0; + + case ADM1266_READ_BLACKBOX: + return 0; + + case ADM1266_BLACKBOX_INFORMATION: + pmbus_send(pmdev, adm1266_blackbox_info, + sizeof(adm1266_blackbox_info)); + break; + default: qemu_log_mask(LOG_UNIMP, "%s: reading from unimplemented register: 0x%02x\n", @@ -154,6 +166,9 @@ static int adm1266_write_data(PMBusDevice *pmdev, const uint8_t *buf, pmbus_receive_block(pmdev, (uint8_t *)s->mfr_rev, sizeof(s->mfr_rev)); break; + case ADM1266_BLACKBOX_CONFIG: + case ADM1266_READ_BLACKBOX: + case ADM1266_BLACKBOX_INFORMATION: case ADM1266_SET_RTC: /* do nothing */ break; -- 2.51.0.rc0.155.g4a0f42376b-goog