From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20EE1CA0EED for ; Thu, 28 Aug 2025 23:26:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+4JW4eGwDdSkIS6UvVtJHitLoUo4W10Im3juuHDQeVc=; b=1VacGIxsVrzdUE98uRlloZZStN 7aFIz/rSkmYC1Y8FitVkhzLoxX+VP70Z1tP/wlghKWCbbjjwoiwmMOcBpueDjH1Fs5hkLZMOxshnJ 0NfWrkzyfu063Tmrv6YvUAk0htToeMfYsahdB0Okczcvd/H9OvOms9KJeDAPUFndLhdnkGWS5b5kl Umq6hHOy3L7MEC0N+6KH1tHI8y/wX+ALVfvtX5ey87Wq4e9CbEzoWCzGp0W+q7nwZEqUV6/4jpThy 2jdyMwQ8MjeZopLKr1f40/vEZquUTFM9PBnNrmzT+we9tYkK7GgQv7UapVvGegIdySVZ6XlA3MBVz vBz/RQMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1urm0k-00000003ezK-0UmH; Thu, 28 Aug 2025 23:26:30 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1urj5d-000000039qW-3Zdr; Thu, 28 Aug 2025 20:19:22 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 3D48E45229; Thu, 28 Aug 2025 20:19:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8182C4CEEB; Thu, 28 Aug 2025 20:19:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756412361; bh=EfjnmzRM4EzcfrEjZb23/Q388aWEyQC6jnzqc5fc3EY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BWYmvZjGSIhGsXSITNjValCU+H/NakH+Ls/Djn/tsb1jdJotNaLCwT5loQOWcouAI L9RCLZblArg6XxZ+165bTtoXHQyfMZbRxY+nq4By7/Vbriu4UDciz9M/fhi292xlfg MlvDF7Q4gmgRW+JnZQb3ugIJFYG51hxAsvnNyrfGhLWRmuR6Q0Z09CQF+EJfYGL/kc ZLYOLaR3Cf0mRUUVYgkqT6Dsu1hWwB2LTJDQceK8ZyzuT6aZQBjTVDVsis5JCRanln EYIsBdufpk0e3794rEjgqj9JtPTkeB3oYtJopEGq552ZGP7crVncu0xWF1Qjhp/ycN 0/2Ql3ZHeRFRw== Date: Thu, 28 Aug 2025 13:19:15 -0700 From: Nathan Chancellor To: Miguel Ojeda Cc: Randy Dunlap , Kees Cook , Kees Cook , Peter Zijlstra , Sami Tolvanen , Linus Walleij , Mark Rutland , Puranjay Mohan , David Woodhouse , Jonathan Corbet , x86@kernel.org, linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org Subject: Re: [PATCH 5/5] kcfi: Rename CONFIG_CFI_CLANG to CONFIG_CFI Message-ID: <20250828201915.GA219815@ax162> References: <20250825141316.work.967-kees@kernel.org> <20250825142603.1907143-5-kees@kernel.org> <202508250834.E2456B9@keescook> <9CCDBE93-7DBD-41D0-B9B6-05900F2AB1EE@outflux.net> <20250827013444.GA2859318@ax162> <56c2b1ce-00a4-403c-9927-79bfd9a23574@infradead.org> <20250827193815.GA2293657@ax162> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250828_131921_931329_2F774A67 X-CRM114-Status: GOOD ( 19.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 28, 2025 at 02:11:51PM +0200, Miguel Ojeda wrote: > On Wed, Aug 27, 2025 at 9:38 PM Nathan Chancellor wrote: > > Another idea I had to avoid this is introducing CONFIG_CFI_GCC as a user > > selectable symbol and making CONFIG_CFI the hidden symbol that both > > compiler symbols select. After a couple of releases (or maybe the next > > LTS), both CONFIG_CFI_CLANG and CONFIG_CFI_GCC could be eliminated with > > CONFIG_CFI becoming user selectable, which would keep things working > > since CONFIG_CFI=y will be present in the previous configuration. > > If we are OK with something like this (i.e. waiting a few releases), > then isn't it simpler the `def_bool` approach I mentioned? i.e. it > means one less symbol and one less rename later, right? Ah yes, I reread your suggestion and that would probably be the best course of action, as it does avoid the extra symbol (although I am not sure what you mean by one less rename?). As I understand it: config CFI_CLANG bool "Use Kernel Control Flow Integrity (kCFI)" depends on ARCH_SUPPORTS_CFI depends on $(cc-option,-fsanitize=kcfi) help config CFI def_bool CFI_CLANG then keep the rest of the change the same with the rename? I guess the CLANG in the symbol name could be confusing for some people but thinking about the timeline more, kCFI would not ship until GCC 16 in the spring of 2026, which would be after the Linux LTS release at the end of 2025. That means we could easily drop CONFIG_CFI_CLANG in the first release of 2026 so that compatible GCC users should only ever see CONFIG_CFI from mainline. They could see CONFIG_CFI_CLANG in the LTS release but at least it would work. Cheers, Nathan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF3AACA0EED for ; Fri, 29 Aug 2025 01:10:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f/RtvydycNyAY60idytOLiAclMIL3neSdFxoqBXx6aU=; b=LAYsS1ZmbtO93V WuXMJAs+u3JlJkq1DOKpOkIWp6lNVV6nWazR7SCiB8xYCA6LCRkGBYntguYpfJxSRtC8Db3JimExe /UihI86U1TC6ylqdMmhyd0/t4yVlitH5hkBrBGJBPHuCM8/JqEF/WkKNsoa67NyjPJ2KCyfeiBgiQ Mu1h8TjTpejkWRTE8UUY/ICJnZ9/MrMO8GwAFsKsMysFKPvKZq69Yqf75O5MUmt1Sk5hU1CgKWhEg n/Ah2w0v0VTEGRObqNKwBjOQsh1E1hNrtmd31bKR1O6CiZXTusT5WqwuIGqNHi3HDVaNBkZhopKeA 3MeDiLIBeVV8Mbv3U9kg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1urndY-00000003xcE-2hb0; Fri, 29 Aug 2025 01:10:40 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1urj5d-000000039qW-3Zdr; Thu, 28 Aug 2025 20:19:22 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 3D48E45229; Thu, 28 Aug 2025 20:19:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8182C4CEEB; Thu, 28 Aug 2025 20:19:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756412361; bh=EfjnmzRM4EzcfrEjZb23/Q388aWEyQC6jnzqc5fc3EY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BWYmvZjGSIhGsXSITNjValCU+H/NakH+Ls/Djn/tsb1jdJotNaLCwT5loQOWcouAI L9RCLZblArg6XxZ+165bTtoXHQyfMZbRxY+nq4By7/Vbriu4UDciz9M/fhi292xlfg MlvDF7Q4gmgRW+JnZQb3ugIJFYG51hxAsvnNyrfGhLWRmuR6Q0Z09CQF+EJfYGL/kc ZLYOLaR3Cf0mRUUVYgkqT6Dsu1hWwB2LTJDQceK8ZyzuT6aZQBjTVDVsis5JCRanln EYIsBdufpk0e3794rEjgqj9JtPTkeB3oYtJopEGq552ZGP7crVncu0xWF1Qjhp/ycN 0/2Ql3ZHeRFRw== Date: Thu, 28 Aug 2025 13:19:15 -0700 From: Nathan Chancellor To: Miguel Ojeda Cc: Randy Dunlap , Kees Cook , Kees Cook , Peter Zijlstra , Sami Tolvanen , Linus Walleij , Mark Rutland , Puranjay Mohan , David Woodhouse , Jonathan Corbet , x86@kernel.org, linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org Subject: Re: [PATCH 5/5] kcfi: Rename CONFIG_CFI_CLANG to CONFIG_CFI Message-ID: <20250828201915.GA219815@ax162> References: <20250825141316.work.967-kees@kernel.org> <20250825142603.1907143-5-kees@kernel.org> <202508250834.E2456B9@keescook> <9CCDBE93-7DBD-41D0-B9B6-05900F2AB1EE@outflux.net> <20250827013444.GA2859318@ax162> <56c2b1ce-00a4-403c-9927-79bfd9a23574@infradead.org> <20250827193815.GA2293657@ax162> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250828_131921_931329_2F774A67 X-CRM114-Status: GOOD ( 19.78 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVGh1LCBBdWcgMjgsIDIwMjUgYXQgMDI6MTE6NTFQTSArMDIwMCwgTWlndWVsIE9qZWRhIHdy b3RlOgo+IE9uIFdlZCwgQXVnIDI3LCAyMDI1IGF0IDk6MzjigK9QTSBOYXRoYW4gQ2hhbmNlbGxv ciA8bmF0aGFuQGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4gQW5vdGhlciBpZGVhIEkgaGFkIHRvIGF2 b2lkIHRoaXMgaXMgaW50cm9kdWNpbmcgQ09ORklHX0NGSV9HQ0MgYXMgYSB1c2VyCj4gPiBzZWxl Y3RhYmxlIHN5bWJvbCBhbmQgbWFraW5nIENPTkZJR19DRkkgdGhlIGhpZGRlbiBzeW1ib2wgdGhh dCBib3RoCj4gPiBjb21waWxlciBzeW1ib2xzIHNlbGVjdC4gQWZ0ZXIgYSBjb3VwbGUgb2YgcmVs ZWFzZXMgKG9yIG1heWJlIHRoZSBuZXh0Cj4gPiBMVFMpLCBib3RoIENPTkZJR19DRklfQ0xBTkcg YW5kIENPTkZJR19DRklfR0NDIGNvdWxkIGJlIGVsaW1pbmF0ZWQgd2l0aAo+ID4gQ09ORklHX0NG SSBiZWNvbWluZyB1c2VyIHNlbGVjdGFibGUsIHdoaWNoIHdvdWxkIGtlZXAgdGhpbmdzIHdvcmtp bmcKPiA+IHNpbmNlIENPTkZJR19DRkk9eSB3aWxsIGJlIHByZXNlbnQgaW4gdGhlIHByZXZpb3Vz IGNvbmZpZ3VyYXRpb24uCj4gCj4gSWYgd2UgYXJlIE9LIHdpdGggc29tZXRoaW5nIGxpa2UgdGhp cyAoaS5lLiB3YWl0aW5nIGEgZmV3IHJlbGVhc2VzKSwKPiB0aGVuIGlzbid0IGl0IHNpbXBsZXIg dGhlIGBkZWZfYm9vbGAgYXBwcm9hY2ggSSBtZW50aW9uZWQ/IGkuZS4gaXQKPiBtZWFucyBvbmUg bGVzcyBzeW1ib2wgYW5kIG9uZSBsZXNzIHJlbmFtZSBsYXRlciwgcmlnaHQ/CgpBaCB5ZXMsIEkg cmVyZWFkIHlvdXIgc3VnZ2VzdGlvbiBhbmQgdGhhdCB3b3VsZCBwcm9iYWJseSBiZSB0aGUgYmVz dApjb3Vyc2Ugb2YgYWN0aW9uLCBhcyBpdCBkb2VzIGF2b2lkIHRoZSBleHRyYSBzeW1ib2wgKGFs dGhvdWdoIEkgYW0gbm90CnN1cmUgd2hhdCB5b3UgbWVhbiBieSBvbmUgbGVzcyByZW5hbWU/KS4g QXMgSSB1bmRlcnN0YW5kIGl0OgoKICBjb25maWcgQ0ZJX0NMQU5HCiAgICAgIGJvb2wgIlVzZSBL ZXJuZWwgQ29udHJvbCBGbG93IEludGVncml0eSAoa0NGSSkiCiAgICAgIGRlcGVuZHMgb24gQVJD SF9TVVBQT1JUU19DRkkKICAgICAgZGVwZW5kcyBvbiAkKGNjLW9wdGlvbiwtZnNhbml0aXplPWtj ZmkpCiAgICAgIGhlbHAKICAgICAgICA8Z2VuZXJpYyBoZWxwIHRleHQ+CgogIGNvbmZpZyBDRkkK ICAgICAgZGVmX2Jvb2wgQ0ZJX0NMQU5HCgp0aGVuIGtlZXAgdGhlIHJlc3Qgb2YgdGhlIGNoYW5n ZSB0aGUgc2FtZSB3aXRoIHRoZSByZW5hbWU/IEkgZ3Vlc3MgdGhlCkNMQU5HIGluIHRoZSBzeW1i b2wgbmFtZSBjb3VsZCBiZSBjb25mdXNpbmcgZm9yIHNvbWUgcGVvcGxlIGJ1dCB0aGlua2luZwph Ym91dCB0aGUgdGltZWxpbmUgbW9yZSwga0NGSSB3b3VsZCBub3Qgc2hpcCB1bnRpbCBHQ0MgMTYg aW4gdGhlIHNwcmluZwpvZiAyMDI2LCB3aGljaCB3b3VsZCBiZSBhZnRlciB0aGUgTGludXggTFRT IHJlbGVhc2UgYXQgdGhlIGVuZCBvZiAyMDI1LgpUaGF0IG1lYW5zIHdlIGNvdWxkIGVhc2lseSBk cm9wIENPTkZJR19DRklfQ0xBTkcgaW4gdGhlIGZpcnN0IHJlbGVhc2Ugb2YKMjAyNiBzbyB0aGF0 IGNvbXBhdGlibGUgR0NDIHVzZXJzIHNob3VsZCBvbmx5IGV2ZXIgc2VlIENPTkZJR19DRkkgZnJv bQptYWlubGluZS4gVGhleSBjb3VsZCBzZWUgQ09ORklHX0NGSV9DTEFORyBpbiB0aGUgTFRTIHJl bGVhc2UgYnV0IGF0CmxlYXN0IGl0IHdvdWxkIHdvcmsuCgpDaGVlcnMsCk5hdGhhbgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFp bGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo=