From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
James Clark <james.clark@linaro.org>,
Xu Yang <xu.yang_2@nxp.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
John Garry <john.g.garry@oracle.com>,
Jing Zhang <renyu.zj@linux.alibaba.com>,
Sandipan Das <sandipan.das@amd.com>,
Benjamin Gray <bgray@linux.ibm.com>,
Perry Taylor <perry.taylor@intel.com>,
Samantha Alt <samantha.alt@intel.com>,
Caleb Biggers <caleb.biggers@intel.com>,
Weilin Wang <weilin.wang@intel.com>,
Edward Baker <edward.baker@intel.com>,
Thomas Falcon <thomas.falcon@intel.com>
Subject: [PATCH v5 04/22] perf jevents: Add smi metric group for Intel models
Date: Thu, 28 Aug 2025 21:10:45 -0700 [thread overview]
Message-ID: <20250829041104.4186320-5-irogers@google.com> (raw)
In-Reply-To: <20250829041104.4186320-1-irogers@google.com>
Allow duplicated metric to be dropped from json files.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/pmu-events/intel_metrics.py | 24 ++++++++++++++++++++++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/tools/perf/pmu-events/intel_metrics.py b/tools/perf/pmu-events/intel_metrics.py
index 0bb28f4c8316..1e4790717cec 100755
--- a/tools/perf/pmu-events/intel_metrics.py
+++ b/tools/perf/pmu-events/intel_metrics.py
@@ -1,8 +1,8 @@
#!/usr/bin/env python3
# SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause)
-from metric import (d_ratio, has_event, max, Event, JsonEncodeMetric,
+from metric import (d_ratio, has_event, max, CheckPmu, Event, JsonEncodeMetric,
JsonEncodeMetricGroupDescriptions, LoadEvents, Metric,
- MetricGroup, Select)
+ MetricGroup, MetricRef, Select)
import argparse
import json
import math
@@ -56,6 +56,25 @@ def Rapl() -> MetricGroup:
description="Running Average Power Limit (RAPL) power consumption estimates")
+def Smi() -> MetricGroup:
+ pmu = "<cpu_core or cpu_atom>" if CheckPmu("cpu_core") else "cpu"
+ aperf = Event('msr/aperf/')
+ cycles = Event('cycles')
+ smi_num = Event('msr/smi/')
+ smi_cycles = Select(Select((aperf - cycles) / aperf, smi_num > 0, 0),
+ has_event(aperf),
+ 0)
+ return MetricGroup('smi', [
+ Metric('smi_num', 'Number of SMI interrupts.',
+ Select(smi_num, has_event(smi_num), 0), 'SMI#'),
+ # Note, the smi_cycles "Event" is really a reference to the metric.
+ Metric('smi_cycles',
+ 'Percentage of cycles spent in System Management Interrupts. '
+ f'Requires /sys/bus/event_source/devices/{pmu}/freeze_on_smi to be 1.',
+ smi_cycles, '100%', threshold=(MetricRef('smi_cycles') > 0.10))
+ ], description = 'System Management Interrupt metrics')
+
+
def main() -> None:
global _args
@@ -81,6 +100,7 @@ def main() -> None:
all_metrics = MetricGroup("", [
Idle(),
Rapl(),
+ Smi(),
])
--
2.51.0.318.gd7df087d1a-goog
next prev parent reply other threads:[~2025-08-29 4:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 4:10 [PATCH v5 00/22] Python generated Intel metrics Ian Rogers
2025-08-29 4:10 ` [PATCH v5 01/22] perf jevents: Add RAPL metrics for all Intel models Ian Rogers
2025-08-29 4:10 ` [PATCH v5 02/22] perf jevents: Add idle metric for " Ian Rogers
2025-08-29 4:10 ` [PATCH v5 03/22] perf jevents: Add CheckPmu to see if a PMU is in loaded json events Ian Rogers
2025-08-29 4:10 ` Ian Rogers [this message]
2025-08-29 4:10 ` [PATCH v5 05/22] perf jevents: Mark metrics with experimental events as experimental Ian Rogers
2025-08-29 4:10 ` [PATCH v5 06/22] perf jevents: Add tsx metric group for Intel models Ian Rogers
2025-08-29 4:10 ` [PATCH v5 07/22] perf jevents: Add br metric group for branch statistics on Intel Ian Rogers
2025-08-29 4:10 ` [PATCH v5 08/22] perf jevents: Add software prefetch (swpf) metric group for Intel Ian Rogers
2025-08-29 4:10 ` [PATCH v5 09/22] perf jevents: Add ports metric group giving utilization on Intel Ian Rogers
2025-08-29 4:10 ` [PATCH v5 10/22] perf jevents: Add L2 metrics for Intel Ian Rogers
2025-08-29 4:10 ` [PATCH v5 11/22] perf jevents: Add load store breakdown metrics ldst " Ian Rogers
2025-08-29 4:10 ` [PATCH v5 12/22] perf jevents: Add ILP metrics " Ian Rogers
2025-08-29 4:10 ` [PATCH v5 13/22] perf jevents: Add context switch " Ian Rogers
2025-08-29 4:10 ` [PATCH v5 14/22] perf jevents: Add FPU " Ian Rogers
2025-08-29 4:10 ` [PATCH v5 15/22] perf jevents: Add Miss Level Parallelism (MLP) metric " Ian Rogers
2025-08-29 4:10 ` [PATCH v5 16/22] perf jevents: Add mem_bw " Ian Rogers
2025-08-29 4:10 ` [PATCH v5 17/22] perf jevents: Add local/remote "mem" breakdown metrics " Ian Rogers
2025-08-29 4:10 ` [PATCH v5 18/22] perf jevents: Add dir " Ian Rogers
2025-08-29 4:11 ` [PATCH v5 19/22] perf jevents: Add C-State metrics from the PCU PMU " Ian Rogers
2025-08-29 4:11 ` [PATCH v5 20/22] perf jevents: Add local/remote miss latency metrics " Ian Rogers
2025-08-29 4:11 ` [PATCH v5 21/22] perf jevents: Add upi_bw metric " Ian Rogers
2025-08-29 4:11 ` [PATCH v5 22/22] perf jevents: Add mesh bandwidth saturation " Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250829041104.4186320-5-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bgray@linux.ibm.com \
--cc=caleb.biggers@intel.com \
--cc=edward.baker@intel.com \
--cc=james.clark@linaro.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=perry.taylor@intel.com \
--cc=peterz@infradead.org \
--cc=renyu.zj@linux.alibaba.com \
--cc=samantha.alt@intel.com \
--cc=sandipan.das@amd.com \
--cc=thomas.falcon@intel.com \
--cc=weilin.wang@intel.com \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.