Re: [PATCH v2 00/19] ALSA: firewire: Use auto-cleanup macros

[Takashi Sakamoto <o-takashi@sakamocchi.jp>]

Hi,

Thanks for your updates.

On Thu, Aug 28, 2025 at 03:27:04PM +0200, Takashi Iwai wrote:
> This is another patch set for cleaning up the code with the recent
> auto-cleanup macros like guard() & co, applied to FireWire sound
> drivers.
> 
> Only code refactoring, and no behavior changes intended.
> 
> 
> Takashi
> 
> v1->v2:
> * Fix missing subject prefix for digi00x
> * Drop superfluous blank lines in scoped_work blocks
> 
> ===
> 
> Takashi Iwai (19):
>   ALSA: firewire: bebob: Use guard() for mutex locks
>   ALSA: firewire: dice: Use guard() for mutex locks
>   ALSA: firewire: digi00x: Use guard() for mutex locks
>   ALSA: firewire: fireworks: Use guard() for mutex locks
>   ALSA: firewire: motu: Use guard() for mutex locks
>   ALSA: firewire: oxfw: Use guard() for mutex locks
>   ALSA: firewire: tascam: Use guard() for mutex locks
>   ALSA: firewire: fireface: Use guard() for mutex locks
>   ALSA: firewire: isight: Use guard() for mutex locks
>   ALSA: firewire: lib: Use guard() for mutex locks
>   ALSA: firewire: bebob: Use guard() for spin locks
>   ALSA: firewire: dice: Use guard() for spin locks
>   ALSA: firewire: digi00x: Use guard() for spin locks
>   ALSA: firewire: fireface: Use guard() for spin locks
>   ALSA: firewire: fireworks: Use guard() for spin locks
>   ALSA: firewire: motu: Use guard() for spin locks
>   ALSA: firewire: oxfw: Use guard() for spin locks
>   ALSA: firewire: tascam: Use guard() for spin locks
>   ALSA: firewire: lib: Use guard() for spin locks

Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

By the way, I found a bug in ALSA firewire-motu driver (that's on me...)
when reviewing the patchset, and sent a patch[1] now to fix it on your
for-linus branch. It could bring a conflict against 16th patch in your set
("ALSA: firewire: motu: Use guard() for spin locks"), and I would like
you to apply it at first (then sent it to upstream), then applying the
conflicted patch with handy changes.

[1] https://lore.kernel.org/linux-sound/20250829233749.366222-1-o-takashi@sakamocchi.jp/T/#u


Thanks

Takashi Sakamoto