From: <Randy.MacLeod@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: [PATCH 1/2] util-linux: include/mount-api-utils: avoid using sys/mount.h
Date: Sat, 30 Aug 2025 13:02:36 -0400 [thread overview]
Message-ID: <20250830170237.3756511-1-Randy.MacLeod@windriver.com> (raw)
From: Randy MacLeod <Randy.MacLeod@windriver.com>
Avoid compile error:
| In file included from /usr/include/linux/fs.h:19,
| from /usr/include/linux/btrfs.h:29,
| from ../sources/util-linux-2.41.1/libmount/src/btrfs.c:18:
| /usr/include/x86_64-linux-gnu/sys/mount.h:35:3: \
error: expected identifier before numeric constant
| 35 | MS_RDONLY = 1, /* Mount read-only. */
| | ^~~~~~~~~
This is seen on PopOS 22.04, an Ubuntu/Debian-based distro.
Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
---
meta/recipes-core/util-linux/util-linux.inc | 1 +
...nt-api-utils-avoid-using-sys-mount.h.patch | 29 +++++++++++++++++++
2 files changed, 30 insertions(+)
create mode 100644 meta/recipes-core/util-linux/util-linux/0001-include-mount-api-utils-avoid-using-sys-mount.h.patch
diff --git a/meta/recipes-core/util-linux/util-linux.inc b/meta/recipes-core/util-linux/util-linux.inc
index c5698d9cab..4c1105b6ae 100644
--- a/meta/recipes-core/util-linux/util-linux.inc
+++ b/meta/recipes-core/util-linux/util-linux.inc
@@ -21,6 +21,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/utils/util-linux/v${MAJOR_VERSION}/util-lin
file://0001-lsfd-mkfds-foreign-sockets-skip-when-lacking-sock_di.patch \
file://0001-ts-kill-decode-use-RTMIN-from-kill-L-instead-of-hard.patch \
file://0001-tests-helpers-test_sigstate.c-explicitly-reset-SIGIN.patch \
+ file://0001-include-mount-api-utils-avoid-using-sys-mount.h.patch \
"
SRC_URI[sha256sum] = "be9ad9a276f4305ab7dd2f5225c8be1ff54352f565ff4dede9628c1aaa7dec57"
diff --git a/meta/recipes-core/util-linux/util-linux/0001-include-mount-api-utils-avoid-using-sys-mount.h.patch b/meta/recipes-core/util-linux/util-linux/0001-include-mount-api-utils-avoid-using-sys-mount.h.patch
new file mode 100644
index 0000000000..544f45362d
--- /dev/null
+++ b/meta/recipes-core/util-linux/util-linux/0001-include-mount-api-utils-avoid-using-sys-mount.h.patch
@@ -0,0 +1,29 @@
+From 2a9b48d20d74f65ac708b3bcee6a7e2a61aadf88 Mon Sep 17 00:00:00 2001
+From: Karel Zak <kzak@redhat.com>
+Date: Thu, 21 Aug 2025 09:59:10 +0200
+Subject: [PATCH] include/mount-api-utils: avoid using sys/mount.h
+
+The file is unnecessary and introduces duplicate #define of MS_* macros.
+
+Fixes: https://github.com/util-linux/util-linux/issues/3674
+Signed-off-by: Karel Zak <kzak@redhat.com>
+Upstream-Status: Backport [https://github.com/util-linux/util-linux/commit/2a9b48d20d74f65ac708b3bcee6a7e2a61aadf88]
+---
+ include/mount-api-utils.h | 1 -
+ 1 file changed, 1 deletion(-)
+
+diff --git a/include/mount-api-utils.h b/include/mount-api-utils.h
+index 920d6766a..e35524168 100644
+--- a/include/mount-api-utils.h
++++ b/include/mount-api-utils.h
+@@ -6,7 +6,6 @@
+ #define UTIL_LINUX_MOUNT_API_UTILS
+
+ #ifdef HAVE_LINUX_MOUNT_H
+-#include <sys/mount.h>
+ #include <linux/mount.h>
+ #include <linux/unistd.h>
+ #include <sys/syscall.h>
+--
+2.34.1
+
--
2.34.1
next reply other threads:[~2025-08-30 17:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-30 17:02 Randy.MacLeod [this message]
2025-08-30 17:02 ` [PATCH 2/2] stress-ng: upgrade 0.19.02 -> 0.19.03 Randy.MacLeod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250830170237.3756511-1-Randy.MacLeod@windriver.com \
--to=randy.macleod@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.