From: Jakub Kicinski <kuba@kernel.org>
To: Simon Horman <horms@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, ecree.xilinx@gmail.com,
gal@nvidia.com, joe@dama.to, linux-kselftest@vger.kernel.org,
shuah@kernel.org
Subject: Re: [PATCH net-next 1/2] selftests: drv-net: rss_ctx: use Netlink for timed reconfig
Date: Mon, 1 Sep 2025 10:26:07 -0700 [thread overview]
Message-ID: <20250901102607.0ee14e3c@kernel.org> (raw)
In-Reply-To: <20250901135008.GC15473@horms.kernel.org>
On Mon, 1 Sep 2025 14:50:08 +0100 Simon Horman wrote:
> > - key = _rss_key_rand(key_len)
> > + ethnl = EthtoolFamily()
> > + key = random.randbytes(key_len)
>
> Is the update to the generation of key intended?
> It's not clear to me how it relates to the rest of the patch.
_rss_key_rand() gives us an array of integers in the range 0-255 while
randomg.randbytes() gives us a bytearray. Difference in return type.
Let me respin and add this to the commit msg. Looks like I was too
aggressive with the decrease in 75msec timing, CI hit a 120msec run :(
next prev parent reply other threads:[~2025-09-01 17:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 22:07 [PATCH net-next 1/2] selftests: drv-net: rss_ctx: use Netlink for timed reconfig Jakub Kicinski
2025-08-29 22:07 ` [PATCH net-next 2/2] selftests: drv-net: rss_ctx: make the test pass with few queues Jakub Kicinski
2025-09-01 13:50 ` [PATCH net-next 1/2] selftests: drv-net: rss_ctx: use Netlink for timed reconfig Simon Horman
2025-09-01 17:26 ` Jakub Kicinski [this message]
2025-09-02 9:01 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250901102607.0ee14e3c@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=joe@dama.to \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.