From: Jakub Kicinski <kuba@kernel.org>
To: Miaoqian Lin <linmq006@gmail.com>
Cc: Marcin Wojtas <marcin.s.wojtas@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: mvpp2: Fix refcount leak in mvpp2_use_acpi_compat_mode
Date: Mon, 1 Sep 2025 12:50:47 -0700 [thread overview]
Message-ID: <20250901125047.4c909ace@kernel.org> (raw)
In-Reply-To: <20250830091854.2111062-1-linmq006@gmail.com>
On Sat, 30 Aug 2025 17:18:54 +0800 Miaoqian Lin wrote:
> - return (!fwnode_property_present(port_fwnode, "phy-handle") &&
> - !fwnode_property_present(port_fwnode, "managed") &&
> - !fwnode_get_named_child_node(port_fwnode, "fixed-link"));
> + if (fwnode_property_present(port_fwnode, "phy-handle") ||
> + fwnode_property_present(port_fwnode, "managed"))
> + return false;
> +
> + fixed_link = fwnode_get_named_child_node(port_fwnode, "fixed-link");
Wouldn't it be easier to switch to fwnode_get_named_child_node_count() ?
--
pw-bot: cr
next prev parent reply other threads:[~2025-09-01 19:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-30 9:18 [PATCH] net: mvpp2: Fix refcount leak in mvpp2_use_acpi_compat_mode Miaoqian Lin
2025-09-01 15:00 ` Simon Horman
2025-09-01 19:50 ` Jakub Kicinski [this message]
2025-09-02 14:09 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250901125047.4c909ace@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linmq006@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marcin.s.wojtas@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.