From: Jakub Kicinski <kuba@kernel.org>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Mengyuan Lou <mengyuanlou@net-swift.com>
Subject: Re: [PATCH net-next v2 2/2] net: wangxun: add RSS reta and rxfh fields support
Date: Mon, 1 Sep 2025 13:51:42 -0700 [thread overview]
Message-ID: <20250901135142.174698ef@kernel.org> (raw)
In-Reply-To: <20250829091752.24436-3-jiawenwu@trustnetic.com>
On Fri, 29 Aug 2025 17:17:52 +0800 Jiawen Wu wrote:
> + u32 max_queues = min_t(u32, wx->num_rx_queues,
> + WX_RSS_INDIR_TBL_MAX);
> +
> + /*Allow at least 2 queues w/ SR-IOV.*/
> + if (test_bit(WX_FLAG_SRIOV_ENABLED, wx->flags) &&
> + max_queues < 2)
> + max_queues = 2;
> +
> + /* Verify user input. */
> + for (i = 0; i < reta_entries; i++)
> + if (rxfh->indir[i] >= max_queues)
> + return -EINVAL;
This looks suspicious, if you report the right number of rings from
GRXRINGS the core will do the check for you.
--
pw-bot: cr
prev parent reply other threads:[~2025-09-01 20:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 9:17 [PATCH net-next v2 0/2] net: wangxun: support to configure RSS Jiawen Wu
2025-08-29 9:17 ` [PATCH net-next v2 1/2] net: libwx: support multiple RSS for every pool Jiawen Wu
2025-08-29 9:17 ` [PATCH net-next v2 2/2] net: wangxun: add RSS reta and rxfh fields support Jiawen Wu
2025-09-01 20:51 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250901135142.174698ef@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiawenwu@trustnetic.com \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.