Re: [PATCH 13/18] cpus: remove TCG-ism from cpu_exit()

[Igor Mammedov <imammedo@redhat.com>]

On Fri, 29 Aug 2025 17:31:10 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Now that TCG has its own kick function, make cpu_exit() do the right kick
> for all accelerators.
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  hw/core/cpu-common.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c
> index ca00accd162..3fa9fa82228 100644
> --- a/hw/core/cpu-common.c
> +++ b/hw/core/cpu-common.c
> @@ -76,9 +76,7 @@ void cpu_exit(CPUState *cpu)
>  {
>      /* Ensure cpu_exec will see the reason why the exit request was set.  */
>      qatomic_store_release(&cpu->exit_request, true);
> -    /* Ensure cpu_exec will see the exit request after TCG has exited.  */
> -    smp_wmb();
> -    qatomic_set(&cpu->neg.icount_decr.u16.high, -1);
> +    qemu_cpu_kick(cpu);
>  }
>  
>  static int cpu_common_gdb_read_register(CPUState *cpu, GByteArray *buf, int reg)