Re: [PATCH linux-5.10.y 1/5] ASoC: Intel: bxt_da7219_max98357a: shrink platform_id below 20 characters

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Sep 01, 2025 at 03:55:29PM +0200, Michał Górny wrote:
> On Mon, 2025-09-01 at 15:25 +0200, Greg KH wrote:
> > On Mon, Sep 01, 2025 at 11:54:36AM +0200, Michał Górny wrote:
> > > From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> > > 
> > > commit 24e46fb811e991f56d5694b10ae7ceb8d2b8c846 upstream.
> > > 
> > > The excessive platform id lengths are causing out-of-buffer reads
> > > in depmod, e.g.:
> > > 
> > > depmod: FATAL: Module index: bad character '�'=0x80 - only 7-bit ASCII is supported:
> > > platform:jsl_rt5682_max98360ax�
> > > 
> > > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> > > Link: https://lore.kernel.org/r/20210511213707.32958-5-pierre-louis.bossart@linux.intel.com
> > > Signed-off-by: Mark Brown <broonie@kernel.org>
> > > Signed-off-by: Michał Górny <mgorny@gentoo.org>
> > 
> > This commit text does not match the upstream commit text at all :(
> > 
> > Same for others in this series, please fix.
> 
> I'm sorry, I've misread the instructions as telling me to describe why I
> believe this deserves to be backported.  It would be really helpful if
> they linked to some good examples.  Should I also keep the original
> Reviewed-by lines?

Yes, keep the original stuff, and if you need extra justification, put
that in a 0/X email header.

thanks,

greg k-h