From: Jakub Kicinski <kuba@kernel.org>
To: Colin Foster <colin.foster@in-advantage.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Steve Glendinning <steve.glendinning@shawell.net>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH v1] smsc911x: add second read of EEPROM mac when possible corruption seen
Date: Tue, 2 Sep 2025 12:05:28 -0700 [thread overview]
Message-ID: <20250902120528.5adc9fb7@kernel.org> (raw)
In-Reply-To: <aLbjkQF8mA5HGDfx@colin-ia-desktop>
On Tue, 2 Sep 2025 07:31:13 -0500 Colin Foster wrote:
> > > + * The first mac_read always returns 0. Re-read it to get the
> > > + * full MAC
> >
> > Always? Strange, why did nobody notice until now?
>
> For me it is 100% reproduceable. The first read is always 0. I've added
> delays in case timing was the issue. I've swapped ADDRH and ADDRL and
> the opposite effect happened (where the first four MAC octets were
> zero). Re-reads always succeed.
>
> Without the patch, the last two MAC octets are always zero.
>
> We didn't notice it until we started hooking multiple devices on the
> same network.
>
> If there is anyone else running this hardware, I'd love verification.
> Its an SMSC9221.
>
> That's a long way of saying "I don't know" unfortunately.
Right, I think we should avoid saying "always" in the comment then.
Let's weasel word it a little bit given the uncertainty..
prev parent reply other threads:[~2025-09-02 19:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 21:44 [PATCH v1] smsc911x: add second read of EEPROM mac when possible corruption seen Colin Foster
2025-09-01 20:57 ` Jakub Kicinski
2025-09-02 12:31 ` Colin Foster
2025-09-02 19:05 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250902120528.5adc9fb7@kernel.org \
--to=kuba@kernel.org \
--cc=colin.foster@in-advantage.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.