Re: [PATCH v3 01/12] arm64: topology: Use scope-based cleanup helper

[kernel test robot <lkp@intel.com>]

Hi Zihuan,

kernel test robot noticed the following build errors:

[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on rafael-pm/bleeding-edge rafael-pm/thermal arm64/for-next/core linus/master v6.17-rc4 next-20250901]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Zihuan-Zhang/arm64-topology-Use-scope-based-cleanup-helper/20250901-170106
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link:    https://lore.kernel.org/r/20250901085748.36795-2-zhangzihuan%40kylinos.cn
patch subject: [PATCH v3 01/12] arm64: topology: Use scope-based cleanup helper
config: arm64-allnoconfig (https://download.01.org/0day-ci/archive/20250902/202509021320.CRevA14c-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250902/202509021320.CRevA14c-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509021320.CRevA14c-lkp@intel.com/

All errors (new ones prefixed by >>):

   arch/arm64/kernel/topology.c: In function 'arch_freq_get_on_cpu':
>> arch/arm64/kernel/topology.c:311:49: error: 'info' undeclared (first use in this function)
     311 |                                 cpufreq_cpu_get(info->opp_cpu);
         |                                                 ^~~~
   arch/arm64/kernel/topology.c:311:49: note: each undeclared identifier is reported only once for each function it appears in


vim +/info +311 arch/arm64/kernel/topology.c

   284	
   285	int arch_freq_get_on_cpu(int cpu)
   286	{
   287		struct amu_cntr_sample *amu_sample;
   288		unsigned int start_cpu = cpu;
   289		unsigned long last_update;
   290		unsigned int freq = 0;
   291		u64 scale;
   292	
   293		if (!amu_fie_cpu_supported(cpu) || !arch_scale_freq_ref(cpu))
   294			return -EOPNOTSUPP;
   295	
   296		while (1) {
   297	
   298			amu_sample = per_cpu_ptr(&cpu_amu_samples, cpu);
   299	
   300			last_update = amu_sample->last_scale_update;
   301	
   302			/*
   303			 * For those CPUs that are in full dynticks mode, or those that have
   304			 * not seen tick for a while, try an alternative source for the counters
   305			 * (and thus freq scale), if available, for given policy: this boils
   306			 * down to identifying an active cpu within the same freq domain, if any.
   307			 */
   308			if (!housekeeping_cpu(cpu, HK_TYPE_TICK) ||
   309			    time_is_before_jiffies(last_update + msecs_to_jiffies(AMU_SAMPLE_EXP_MS))) {
   310				struct cpufreq_policy *policy __free(put_cpufreq_policy) =
 > 311					cpufreq_cpu_get(info->opp_cpu);
   312				int ref_cpu;
   313	
   314				if (!policy)
   315					return -EINVAL;
   316	
   317				if (!cpumask_intersects(policy->related_cpus,
   318							housekeeping_cpumask(HK_TYPE_TICK)))
   319					return -EOPNOTSUPP;
   320	
   321				for_each_cpu_wrap(ref_cpu, policy->cpus, cpu + 1) {
   322					if (ref_cpu == start_cpu) {
   323						/* Prevent verifying same CPU twice */
   324						ref_cpu = nr_cpu_ids;
   325						break;
   326					}
   327					if (!idle_cpu(ref_cpu))
   328						break;
   329				}
   330	
   331				if (ref_cpu >= nr_cpu_ids)
   332					/* No alternative to pull info from */
   333					return -EAGAIN;
   334	
   335				cpu = ref_cpu;
   336			} else {
   337				break;
   338			}
   339		}
   340		/*
   341		 * Reversed computation to the one used to determine
   342		 * the arch_freq_scale value
   343		 * (see amu_scale_freq_tick for details)
   344		 */
   345		scale = arch_scale_freq_capacity(cpu);
   346		freq = scale * arch_scale_freq_ref(cpu);
   347		freq >>= SCHED_CAPACITY_SHIFT;
   348		return freq;
   349	}
   350	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki