diff for duplicates of <202509022308.CeaKUqJM-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index c28fecb..5a80bf0 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,81 +1,43 @@ -BCC: lkp@intel.com -CC: oe-kbuild-all@lists.linux.dev -In-Reply-To: <20250901085748.36795-13-zhangzihuan@kylinos.cn> -References: <20250901085748.36795-13-zhangzihuan@kylinos.cn> -TO: Zihuan Zhang <zhangzihuan@kylinos.cn> -TO: "Rafael J . wysocki" <rafael@kernel.org> -TO: Viresh Kumar <viresh.kumar@linaro.org> -TO: Catalin Marinas <catalin.marinas@arm.com> -TO: Will Deacon <will@kernel.org> -TO: Borislav Petkov <bp@alien8.de> -TO: Dave Hansen <dave.hansen@linux.intel.com> -TO: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> -TO: Michael Ellerman <mpe@ellerman.id.au> -TO: Krzysztof Kozlowski <krzk@kernel.org> -TO: Alim Akhtar <alim.akhtar@samsung.com> -TO: Thierry Reding <thierry.reding@gmail.com> -TO: MyungJoo Ham <myungjoo.ham@samsung.com> -TO: Kyungmin Park <kyungmin.park@samsung.com> -TO: Chanwoo Choi <cw00.choi@samsung.com> -TO: Jani Nikula <jani.nikula@linux.intel.com> -TO: Rodrigo Vivi <rodrigo.vivi@intel.com> -TO: Tvrtko Ursulin <tursulin@ursulin.net> -TO: David Airlie <airlied@gmail.com> -TO: Simona Vetter <simona@ffwll.ch> -TO: Daniel Lezcano <daniel.lezcano@kernel.org> -TO: Sascha Hauer <s.hauer@pengutronix.de> -TO: Shawn Guo <shawnguo@kernel.org> -TO: Eduardo Valentin <edubezval@gmail.com> -TO: Keerthy <j-keerthy@ti.com> -CC: Ben Horgan <ben.horgan@arm.com> -CC: zhenglifeng <zhenglifeng1@huawei.com> -CC: Zhang Rui <rui.zhang@intel.com> -CC: Len Brown <lenb@kernel.org> -CC: Lukasz Luba <lukasz.luba@arm.com> -CC: Pengutronix Kernel Team <kernel@pengutronix.de> - Hi Zihuan, kernel test robot noticed the following build warnings: -[auto build test WARNING on rafael-pm/linux-next] -[also build test WARNING on rafael-pm/bleeding-edge rafael-pm/thermal arm64/for-next/core linus/master v6.17-rc4 next-20250902] -[If your patch is applied to the wrong git tree, kindly drop us a note. -And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Zihuan-Zhang/arm64-topology-Use-scope-based-cleanup-helper/20250901-170106 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next patch link: https://lore.kernel.org/r/20250901085748.36795-13-zhangzihuan%40kylinos.cn patch subject: [PATCH v3 12/12] PM: EM: Use scope-based cleanup helper -:::::: branch date: 30 hours ago -:::::: commit date: 30 hours ago config: powerpc64-randconfig-r071-20250902 (https://download.01.org/0day-ci/archive/20250902/202509022308.CeaKUqJM-lkp@intel.com/config) compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 2e122990391b2ba062e6308a12cfedf7206270ba) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> -| Reported-by: Dan Carpenter <error27@gmail.com> +| Reported-by: Dan Carpenter <dan.carpenter@linaro.org> | Closes: https://lore.kernel.org/r/202509022308.CeaKUqJM-lkp@intel.com/ smatch warnings: kernel/power/energy_model.c:454 em_cpufreq_update_efficiencies() error: uninitialized symbol 'policy'. -kernel/power/energy_model.c:454 em_cpufreq_update_efficiencies() error: uninitialized symbol 'policy'. vim +/policy +454 kernel/power/energy_model.c -1bc138c6229599 Lukasz Luba 2020-06-10 449 e7b1cc9a7ea6d7 Lukasz Luba 2024-02-08 450 static void e7b1cc9a7ea6d7 Lukasz Luba 2024-02-08 451 em_cpufreq_update_efficiencies(struct device *dev, struct em_perf_state *table) e458716a92b57f Vincent Donnefort 2021-09-08 452 { e458716a92b57f Vincent Donnefort 2021-09-08 453 struct em_perf_domain *pd = dev->em_pd; 3a096464b04b72 Zihuan Zhang 2025-09-01 @454 struct cpufreq_policy *policy __free(put_cpufreq_policy); + +policy needs to be set to NULL here. + e458716a92b57f Vincent Donnefort 2021-09-08 455 int found = 0; 99907d6054f2d3 Lukasz Luba 2024-02-08 456 int i, cpu; e458716a92b57f Vincent Donnefort 2021-09-08 457 e7b1cc9a7ea6d7 Lukasz Luba 2024-02-08 458 if (!_is_cpu_device(dev)) e458716a92b57f Vincent Donnefort 2021-09-08 459 return; + ^^^^^^ +returning before an initialization is an uninitialized variable bug. + e458716a92b57f Vincent Donnefort 2021-09-08 460 99907d6054f2d3 Lukasz Luba 2024-02-08 461 /* Try to get a CPU which is active and in this PD */ 99907d6054f2d3 Lukasz Luba 2024-02-08 462 cpu = cpumask_first_and(em_span_cpus(pd), cpu_active_mask); @@ -85,6 +47,11 @@ e458716a92b57f Vincent Donnefort 2021-09-08 460 99907d6054f2d3 Lukasz Luba 2024-02-08 466 } 99907d6054f2d3 Lukasz Luba 2024-02-08 467 99907d6054f2d3 Lukasz Luba 2024-02-08 468 policy = cpufreq_cpu_get(cpu); + +Or we could declare it here: + + struct cpufreq_policy *policy __free(put_cpufreq_policy) = cpufreq_cpu_get(cpu); + e458716a92b57f Vincent Donnefort 2021-09-08 469 if (!policy) { 4274521fabee05 Lukasz Luba 2024-02-08 470 dev_warn(dev, "EM: Access to CPUFreq policy failed\n"); e458716a92b57f Vincent Donnefort 2021-09-08 471 return; @@ -107,7 +74,6 @@ e458716a92b57f Vincent Donnefort 2021-09-08 487 * will be skipped. The EM ca e458716a92b57f Vincent Donnefort 2021-09-08 488 */ e458716a92b57f Vincent Donnefort 2021-09-08 489 pd->flags |= EM_PERF_DOMAIN_SKIP_INEFFICIENCIES; e458716a92b57f Vincent Donnefort 2021-09-08 490 } -e458716a92b57f Vincent Donnefort 2021-09-08 491 -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index 608e07f..f72caf8 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,89 +1,83 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "ref\020250901085748.36795-13-zhangzihuan@kylinos.cn\0" + "From\0Dan Carpenter <dan.carpenter@linaro.org>\0" "Subject\0Re: [PATCH v3 12/12] PM: EM: Use scope-based cleanup helper\0" - "Date\0Tue, 2 Sep 2025 23:25:13 +0800\0" - "To\0oe-kbuild@lists.linux.dev\0" + "Date\0Tue, 2 Sep 2025 18:53:20 +0300\0" + "To\0oe-kbuild@lists.linux.dev" + Zihuan Zhang <zhangzihuan@kylinos.cn> + Rafael J . wysocki <rafael@kernel.org> + Viresh Kumar <viresh.kumar@linaro.org> + Catalin Marinas <catalin.marinas@arm.com> + Will Deacon <will@kernel.org> + Borislav Petkov <bp@alien8.de> + Dave Hansen <dave.hansen@linux.intel.com> + Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> + Michael Ellerman <mpe@ellerman.id.au> + Krzysztof Kozlowski <krzk@kernel.org> + Alim Akhtar <alim.akhtar@samsung.com> + Thierry Reding <thierry.reding@gmail.com> + MyungJoo Ham <myungjoo.ham@samsung.com> + Kyungmin Park <kyungmin.park@samsung.com> + Chanwoo Choi <cw00.choi@samsung.com> + Jani Nikula <jani.nikula@linux.intel.com> + Rodrigo Vivi <rodrigo.vivi@intel.com> + Tvrtko Ursulin <tursulin@ursulin.net> + David Airlie <airlied@gmail.com> + Simona Vetter <simona@ffwll.ch> + Daniel Lezcano <daniel.lezcano@kernel.org> + Sascha Hauer <s.hauer@pengutronix.de> + Shawn Guo <shawnguo@kernel.org> + Eduardo Valentin <edubezval@gmail.com> + " Keerthy <j-keerthy@ti.com>\0" "Cc\0lkp@intel.com" - " Dan Carpenter <error27@gmail.com>\0" + oe-kbuild-all@lists.linux.dev + Ben Horgan <ben.horgan@arm.com> + zhenglifeng <zhenglifeng1@huawei.com> + Zhang Rui <rui.zhang@intel.com> + Len Brown <lenb@kernel.org> + Lukasz Luba <lukasz.luba@arm.com> + " Pengutronix Kernel Team <kernel@pengutronix.de>\0" "\00:1\0" "b\0" - "BCC: lkp@intel.com\n" - "CC: oe-kbuild-all@lists.linux.dev\n" - "In-Reply-To: <20250901085748.36795-13-zhangzihuan@kylinos.cn>\n" - "References: <20250901085748.36795-13-zhangzihuan@kylinos.cn>\n" - "TO: Zihuan Zhang <zhangzihuan@kylinos.cn>\n" - "TO: \"Rafael J . wysocki\" <rafael@kernel.org>\n" - "TO: Viresh Kumar <viresh.kumar@linaro.org>\n" - "TO: Catalin Marinas <catalin.marinas@arm.com>\n" - "TO: Will Deacon <will@kernel.org>\n" - "TO: Borislav Petkov <bp@alien8.de>\n" - "TO: Dave Hansen <dave.hansen@linux.intel.com>\n" - "TO: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>\n" - "TO: Michael Ellerman <mpe@ellerman.id.au>\n" - "TO: Krzysztof Kozlowski <krzk@kernel.org>\n" - "TO: Alim Akhtar <alim.akhtar@samsung.com>\n" - "TO: Thierry Reding <thierry.reding@gmail.com>\n" - "TO: MyungJoo Ham <myungjoo.ham@samsung.com>\n" - "TO: Kyungmin Park <kyungmin.park@samsung.com>\n" - "TO: Chanwoo Choi <cw00.choi@samsung.com>\n" - "TO: Jani Nikula <jani.nikula@linux.intel.com>\n" - "TO: Rodrigo Vivi <rodrigo.vivi@intel.com>\n" - "TO: Tvrtko Ursulin <tursulin@ursulin.net>\n" - "TO: David Airlie <airlied@gmail.com>\n" - "TO: Simona Vetter <simona@ffwll.ch>\n" - "TO: Daniel Lezcano <daniel.lezcano@kernel.org>\n" - "TO: Sascha Hauer <s.hauer@pengutronix.de>\n" - "TO: Shawn Guo <shawnguo@kernel.org>\n" - "TO: Eduardo Valentin <edubezval@gmail.com>\n" - "TO: Keerthy <j-keerthy@ti.com>\n" - "CC: Ben Horgan <ben.horgan@arm.com>\n" - "CC: zhenglifeng <zhenglifeng1@huawei.com>\n" - "CC: Zhang Rui <rui.zhang@intel.com>\n" - "CC: Len Brown <lenb@kernel.org>\n" - "CC: Lukasz Luba <lukasz.luba@arm.com>\n" - "CC: Pengutronix Kernel Team <kernel@pengutronix.de>\n" - "\n" "Hi Zihuan,\n" "\n" "kernel test robot noticed the following build warnings:\n" "\n" - "[auto build test WARNING on rafael-pm/linux-next]\n" - "[also build test WARNING on rafael-pm/bleeding-edge rafael-pm/thermal arm64/for-next/core linus/master v6.17-rc4 next-20250902]\n" - "[If your patch is applied to the wrong git tree, kindly drop us a note.\n" - "And when submitting patch, we suggest to use '--base' as documented in\n" "https://git-scm.com/docs/git-format-patch#_base_tree_information]\n" "\n" "url: https://github.com/intel-lab-lkp/linux/commits/Zihuan-Zhang/arm64-topology-Use-scope-based-cleanup-helper/20250901-170106\n" "base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next\n" "patch link: https://lore.kernel.org/r/20250901085748.36795-13-zhangzihuan%40kylinos.cn\n" "patch subject: [PATCH v3 12/12] PM: EM: Use scope-based cleanup helper\n" - ":::::: branch date: 30 hours ago\n" - ":::::: commit date: 30 hours ago\n" "config: powerpc64-randconfig-r071-20250902 (https://download.01.org/0day-ci/archive/20250902/202509022308.CeaKUqJM-lkp@intel.com/config)\n" "compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 2e122990391b2ba062e6308a12cfedf7206270ba)\n" "\n" "If you fix the issue in a separate patch/commit (i.e. not just a new version of\n" "the same patch/commit), kindly add following tags\n" "| Reported-by: kernel test robot <lkp@intel.com>\n" - "| Reported-by: Dan Carpenter <error27@gmail.com>\n" + "| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>\n" "| Closes: https://lore.kernel.org/r/202509022308.CeaKUqJM-lkp@intel.com/\n" "\n" "smatch warnings:\n" "kernel/power/energy_model.c:454 em_cpufreq_update_efficiencies() error: uninitialized symbol 'policy'.\n" - "kernel/power/energy_model.c:454 em_cpufreq_update_efficiencies() error: uninitialized symbol 'policy'.\n" "\n" "vim +/policy +454 kernel/power/energy_model.c\n" "\n" - "1bc138c6229599 Lukasz Luba 2020-06-10 449 \n" "e7b1cc9a7ea6d7 Lukasz Luba 2024-02-08 450 static void\n" "e7b1cc9a7ea6d7 Lukasz Luba 2024-02-08 451 em_cpufreq_update_efficiencies(struct device *dev, struct em_perf_state *table)\n" "e458716a92b57f Vincent Donnefort 2021-09-08 452 {\n" "e458716a92b57f Vincent Donnefort 2021-09-08 453 \tstruct em_perf_domain *pd = dev->em_pd;\n" "3a096464b04b72 Zihuan Zhang 2025-09-01 @454 \tstruct cpufreq_policy *policy __free(put_cpufreq_policy);\n" + "\n" + "policy needs to be set to NULL here.\n" + "\n" "e458716a92b57f Vincent Donnefort 2021-09-08 455 \tint found = 0;\n" "99907d6054f2d3 Lukasz Luba 2024-02-08 456 \tint i, cpu;\n" "e458716a92b57f Vincent Donnefort 2021-09-08 457 \n" "e7b1cc9a7ea6d7 Lukasz Luba 2024-02-08 458 \tif (!_is_cpu_device(dev))\n" "e458716a92b57f Vincent Donnefort 2021-09-08 459 \t\treturn;\n" + " ^^^^^^\n" + "returning before an initialization is an uninitialized variable bug.\n" + "\n" "e458716a92b57f Vincent Donnefort 2021-09-08 460 \n" "99907d6054f2d3 Lukasz Luba 2024-02-08 461 \t/* Try to get a CPU which is active and in this PD */\n" "99907d6054f2d3 Lukasz Luba 2024-02-08 462 \tcpu = cpumask_first_and(em_span_cpus(pd), cpu_active_mask);\n" @@ -93,6 +87,11 @@ "99907d6054f2d3 Lukasz Luba 2024-02-08 466 \t}\n" "99907d6054f2d3 Lukasz Luba 2024-02-08 467 \n" "99907d6054f2d3 Lukasz Luba 2024-02-08 468 \tpolicy = cpufreq_cpu_get(cpu);\n" + "\n" + "Or we could declare it here:\n" + "\n" + "\tstruct cpufreq_policy *policy __free(put_cpufreq_policy) = cpufreq_cpu_get(cpu);\n" + "\n" "e458716a92b57f Vincent Donnefort 2021-09-08 469 \tif (!policy) {\n" "4274521fabee05 Lukasz Luba 2024-02-08 470 \t\tdev_warn(dev, \"EM: Access to CPUFreq policy failed\\n\");\n" "e458716a92b57f Vincent Donnefort 2021-09-08 471 \t\treturn;\n" @@ -115,10 +114,9 @@ "e458716a92b57f Vincent Donnefort 2021-09-08 488 \t */\n" "e458716a92b57f Vincent Donnefort 2021-09-08 489 \tpd->flags |= EM_PERF_DOMAIN_SKIP_INEFFICIENCIES;\n" "e458716a92b57f Vincent Donnefort 2021-09-08 490 }\n" - "e458716a92b57f Vincent Donnefort 2021-09-08 491 \n" "\n" "-- \n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -012a4ca4ab0a122f611f1aae9754fb3e885046388d693d14ff8e7d334e125108 +78709122881561aea743c9b0739c56ab034ab0d076a09b4cac7df272194fde16
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.