From: Lee Jones <lee@kernel.org>
To: Marcos Del Sol Vives <marcos@orca.pet>
Cc: linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Michael Walle <mwalle@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-gpio@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v4 3/3] mfd: vortex: implement new driver for Vortex southbridges
Date: Wed, 3 Sep 2025 10:14:37 +0100 [thread overview]
Message-ID: <20250903091437.GF2163762@google.com> (raw)
In-Reply-To: <4057768b-82f3-4b5b-b301-afae30bd5bca@orca.pet>
On Wed, 03 Sep 2025, Marcos Del Sol Vives wrote:
> El 03/09/2025 a las 9:21, Lee Jones escribió:
> >> vortex_dx_sb are "struct vortex_southbridge" type, not raw MFD API data.
> >
> > I like your style, but nope!
> >
> > vortex_southbridge contains MFD data and shouldn't exist anyway.
>
> I'm not sure if I follow.
>
> You're suggesting not using driver_data at all and using a big "if" instead,
> matching manually myself on the correct cells to register against the PCI
> device ID, instead of relying on PCI matching giving me already the cells
> structure inside driver_data?
Yes.
> That seems to increase code size and be more error prone for no reason.
It may make sense for your use-case, but believe me, I've seen some
crazy implementations of this. I found it's easier just to have a no
cross contamination of early init APSs rule and call it a day.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2025-09-03 9:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 13:58 [PATCH v4 0/3] Introduce support for Vortex GPIO pins Marcos Del Sol Vives
2025-08-22 13:58 ` [PATCH v4 1/3] gpio: gpio-regmap: add flag to set direction before value Marcos Del Sol Vives
2025-08-22 13:58 ` [PATCH v4 2/3] gpio: vortex: add new GPIO device driver Marcos Del Sol Vives
2025-08-24 7:42 ` William Breathitt Gray
2025-08-22 13:58 ` [PATCH v4 3/3] mfd: vortex: implement new driver for Vortex southbridges Marcos Del Sol Vives
2025-09-02 15:18 ` Lee Jones
2025-09-02 18:06 ` Marcos Del Sol Vives
2025-09-03 7:21 ` Lee Jones
2025-09-03 7:43 ` Marcos Del Sol Vives
2025-09-03 9:14 ` Lee Jones [this message]
2025-09-03 13:01 ` Marcos Del Sol Vives
2025-09-03 14:01 ` Lee Jones
2025-09-03 14:48 ` Marcos Del Sol Vives
2025-09-04 10:17 ` Lee Jones
2025-09-04 12:21 ` Marcos Del Sol Vives
2025-09-08 14:24 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250903091437.GF2163762@google.com \
--to=lee@kernel.org \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marcos@orca.pet \
--cc=mwalle@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.