From: Lee Jones <lee@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Dzmitry Sankouski <dsankouski@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: max77705: rework interrupts
Date: Wed, 3 Sep 2025 13:38:22 +0100 [thread overview]
Message-ID: <20250903123822.GO2163762@google.com> (raw)
In-Reply-To: <33eb49c4-aacf-46ec-a7c2-94ec8cba0243@kernel.org>
On Sun, 31 Aug 2025, Krzysztof Kozlowski wrote:
> On 31/08/2025 00:13, Dzmitry Sankouski wrote:
> > Current implementation describes only MFD's own topsys interrupts.
> > However, max77705 has a register which indicates interrupt source, i.e.
> > it acts as an interrupt controller. There's 4 interrupt sources in
> > max77705: topsys, charger, fuelgauge, usb type-c manager.
> >
> > Setup max77705 MFD parent as an interrupt controller. Leave topsys
> > interrupts unregistered, because currently unused.
>
> Then you should remove them from the driver.
Right.
>> drivers/mfd/max77705.c:89:37: warning: unused variable 'max77705_topsys_irq_chip' [-Wunused-const-variable]
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2025-09-03 12:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-30 22:13 [PATCH] mfd: max77705: rework interrupts Dzmitry Sankouski
2025-08-31 0:02 ` kernel test robot
2025-08-31 8:29 ` Krzysztof Kozlowski
2025-09-03 12:38 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250903123822.GO2163762@google.com \
--to=lee@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=dsankouski@gmail.com \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.