From: Simon Horman <horms@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net 1/2] net: phylink: add lock for serializing concurrent pl->phydev writes with resolver
Date: Wed, 3 Sep 2025 19:48:58 +0100 [thread overview]
Message-ID: <20250903184858.GF361157@horms.kernel.org> (raw)
In-Reply-To: <20250903152348.2998651-1-vladimir.oltean@nxp.com>
On Wed, Sep 03, 2025 at 06:23:47PM +0300, Vladimir Oltean wrote:
...
> @@ -1582,8 +1584,11 @@ static void phylink_resolve(struct work_struct *w)
> struct phylink_link_state link_state;
> bool mac_config = false;
> bool retrigger = false;
> + struct phy_device *phy;
> bool cur_link_state;
>
> + mutex_lock(&pl->phy_lock);
> + phy = pl->phydev;
Hi Vladimir,
I guess this is an artifact of the development of this patchset.
Whatever the case, phy is set but otherwise unused in this function.
This makes CI lightup like a Christmas tree.
And it's a bit too early in the year for that.
> mutex_lock(&pl->state_mutex);
> cur_link_state = phylink_link_is_up(pl);
>
...
--
pw-bot: cr
next prev parent reply other threads:[~2025-09-03 18:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 15:23 [PATCH v2 net 1/2] net: phylink: add lock for serializing concurrent pl->phydev writes with resolver Vladimir Oltean
2025-09-03 15:23 ` [PATCH v2 net 2/2] net: phy: transfer phy_config_inband() locking responsibility to phylink Vladimir Oltean
2025-09-03 15:26 ` [PATCH v2 net 1/2] net: phylink: add lock for serializing concurrent pl->phydev writes with resolver Russell King (Oracle)
2025-09-03 15:31 ` Vladimir Oltean
2025-09-03 15:52 ` Russell King (Oracle)
2025-09-03 17:04 ` Vladimir Oltean
2025-09-03 18:48 ` Simon Horman [this message]
2025-09-03 19:01 ` Vladimir Oltean
2025-09-04 8:42 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250903184858.GF361157@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.