All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Cc: oe-kbuild-all@lists.linux.dev, linux-gpio@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>
Subject: [brgl:gpio/for-next 45/49] drivers/gpio/gpio-nomadik.c:403:27: warning: unused variable 'desc'
Date: Wed, 3 Sep 2025 21:07:25 +0800	[thread overview]
Message-ID: <202509032125.nXBcPuaf-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next
head:   3be2d43534aab7291b59c4e66526f911854aa3a7
commit: ddeb66d2cb10f03a43d97a0ff2c3869d1951c87d [45/49] gpio: nomadik: don't print out global GPIO numbers in debugfs callbacks
config: i386-buildonly-randconfig-001-20250903 (https://download.01.org/0day-ci/archive/20250903/202509032125.nXBcPuaf-lkp@intel.com/config)
compiler: gcc-13 (Debian 13.3.0-16) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250903/202509032125.nXBcPuaf-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509032125.nXBcPuaf-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/gpio/gpio-nomadik.c: In function 'nmk_gpio_dbg_show_one':
>> drivers/gpio/gpio-nomadik.c:403:27: warning: unused variable 'desc' [-Wunused-variable]
     403 |         struct gpio_desc *desc;
         |                           ^~~~


vim +/desc +403 drivers/gpio/gpio-nomadik.c

   398	
   399	void nmk_gpio_dbg_show_one(struct seq_file *s, struct pinctrl_dev *pctldev,
   400				   struct gpio_chip *chip, unsigned int offset)
   401	{
   402		struct nmk_gpio_chip *nmk_chip = gpiochip_get_data(chip);
 > 403		struct gpio_desc *desc;
   404		int mode;
   405		bool is_out;
   406		bool data_out;
   407		bool pull;
   408		static const char * const modes[] = {
   409			[NMK_GPIO_ALT_GPIO]	= "gpio",
   410			[NMK_GPIO_ALT_A]	= "altA",
   411			[NMK_GPIO_ALT_B]	= "altB",
   412			[NMK_GPIO_ALT_C]	= "altC",
   413			[NMK_GPIO_ALT_C + 1]	= "altC1",
   414			[NMK_GPIO_ALT_C + 2]	= "altC2",
   415			[NMK_GPIO_ALT_C + 3]	= "altC3",
   416			[NMK_GPIO_ALT_C + 4]	= "altC4",
   417		};
   418	
   419		char *label = gpiochip_dup_line_label(chip, offset);
   420		if (IS_ERR(label))
   421			return;
   422	
   423		clk_enable(nmk_chip->clk);
   424		is_out = !!(readl(nmk_chip->addr + NMK_GPIO_DIR) & BIT(offset));
   425		pull = !(readl(nmk_chip->addr + NMK_GPIO_PDIS) & BIT(offset));
   426		data_out = !!(readl(nmk_chip->addr + NMK_GPIO_DAT) & BIT(offset));
   427		mode = nmk_gpio_get_mode(nmk_chip, offset);
   428	#ifdef CONFIG_PINCTRL_NOMADIK
   429		if (mode == NMK_GPIO_ALT_C && pctldev) {
   430			desc = gpio_device_get_desc(chip->gpiodev, offset);
   431			mode = nmk_prcm_gpiocr_get_mode(pctldev, desc_to_gpio(desc));
   432		}
   433	#endif
   434	
   435		if (is_out) {
   436			seq_printf(s, " gpio-%-3d (%-20.20s) out %s           %s",
   437				   offset, label ?: "(none)", str_hi_lo(data_out),
   438				   (mode < 0) ? "unknown" : modes[mode]);
   439		} else {
   440			int irq = chip->to_irq(chip, offset);
   441			const int pullidx = pull ? 1 : 0;
   442			int val;
   443			static const char * const pulls[] = {
   444				"none        ",
   445				"pull enabled",
   446			};
   447	
   448			seq_printf(s, " gpio-%-3d (%-20.20s) in  %s %s",
   449				   offset, label ?: "(none)", pulls[pullidx],
   450				   (mode < 0) ? "unknown" : modes[mode]);
   451	
   452			val = nmk_gpio_get_input(chip, offset);
   453			seq_printf(s, " VAL %d", val);
   454	
   455			/*
   456			 * This races with request_irq(), set_irq_type(),
   457			 * and set_irq_wake() ... but those are "rare".
   458			 */
   459			if (irq > 0 && irq_has_action(irq)) {
   460				char *trigger;
   461				bool wake;
   462	
   463				if (nmk_chip->edge_rising & BIT(offset))
   464					trigger = "edge-rising";
   465				else if (nmk_chip->edge_falling & BIT(offset))
   466					trigger = "edge-falling";
   467				else
   468					trigger = "edge-undefined";
   469	
   470				wake = !!(nmk_chip->real_wake & BIT(offset));
   471	
   472				seq_printf(s, " irq-%d %s%s",
   473					   irq, trigger, wake ? " wakeup" : "");
   474			}
   475		}
   476		clk_disable(nmk_chip->clk);
   477	}
   478	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2025-09-03 13:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202509032125.nXBcPuaf-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.