From: Jakub Kicinski <kuba@kernel.org>
To: ALOK TIWARI <alok.a.tiwari@oracle.com>
Cc: Simon Horman <horms@kernel.org>,
dsahern@kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org
Subject: Re: [External] : Re: [PATCH net-next] udp_tunnel: Fix typo using netdev_WARN instead of netdev_warn
Date: Thu, 4 Sep 2025 08:52:41 -0700 [thread overview]
Message-ID: <20250904085241.3bd40e33@kernel.org> (raw)
In-Reply-To: <f45be394-9130-4452-afec-c441f6857708@oracle.com>
On Thu, 4 Sep 2025 20:11:36 +0530 ALOK TIWARI wrote:
> In this case, udp_tunnel_nic_register() returning an error is
> just a failed operation, not a kernel bug. So a simple warning
> message is appropriate, and netdev_warn() should be used
> instead of netdev_WARN().
The distinction should be that WARN is only used in cases which
author of the code expects never to occur.
next prev parent reply other threads:[~2025-09-04 15:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 19:57 [PATCH net-next] udp_tunnel: Fix typo using netdev_WARN instead of netdev_warn Alok Tiwari
2025-09-04 9:18 ` Simon Horman
2025-09-04 13:45 ` [External] : " ALOK TIWARI
2025-09-04 14:28 ` Jakub Kicinski
2025-09-04 14:41 ` ALOK TIWARI
2025-09-04 15:52 ` Jakub Kicinski [this message]
2025-09-04 18:48 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250904085241.3bd40e33@kernel.org \
--to=kuba@kernel.org \
--cc=alok.a.tiwari@oracle.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.