From: Jakub Kicinski <kuba@kernel.org>
To: Alexandra Winter <wintera@linux.ibm.com>
Cc: "D. Wythe" <alibuda@linux.alibaba.com>,
Dust Li <dust.li@linux.alibaba.com>,
Sidraya Jayagond <sidraya@linux.ibm.com>,
Wenjia Zhang <wenjia@linux.ibm.com>,
Aswin Karuvally <aswin@linux.ibm.com>,
David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Mahanta Jambigi <mjambigi@linux.ibm.com>,
Tony Lu <tonylu@linux.alibaba.com>,
Wen Gu <guwen@linux.alibaba.com>,
netdev@vger.kernel.org, linux-s390@vger.kernel.org,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Simon Horman <horms@kernel.org>
Subject: Re: [PATCH net-next 1/2] s390/ism: Log module load/unload
Date: Thu, 4 Sep 2025 08:59:06 -0700 [thread overview]
Message-ID: <20250904085906.46d9bfe0@kernel.org> (raw)
In-Reply-To: <5177c2da-4158-4b12-996d-831ff1ab0708@linux.ibm.com>
On Thu, 4 Sep 2025 09:16:27 +0200 Alexandra Winter wrote:
> On 04.09.25 01:42, Jakub Kicinski wrote:
> > On Mon, 1 Sep 2025 16:58:41 +0200 Alexandra Winter wrote:
> >> Add log messages to visualize timeline of module loads and unloads.
> >
> > How deeply do you care about this patch ? I understand the benefit when
> > debugging "interface doesn't exist" issues with just logs at hand.
> > OTOH seeing a litany of "hello" messages on every boot from built-in
> > drivers, is rather annoying. Perhaps this being an s390 driver makes
> > it a bit of a special case..
>
> tl dr: I don't care very deeply
>
> I think s390 users care a lot about debugability and are less concerned
> about log size. As you said, many other modules (on s390) have these
> 'hello' messages, so I kind of expected the ism module to show up as well.
> But if you want to reject it, we can live without it ;-)
Let me take only the second patch from the series, then. Thanks!
next prev parent reply other threads:[~2025-09-04 15:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 14:58 [PATCH net-next 0/2] net/smc and s390/ism: Improve log messages Alexandra Winter
2025-09-01 14:58 ` [PATCH net-next 1/2] s390/ism: Log module load/unload Alexandra Winter
2025-09-02 8:54 ` Simon Horman
2025-09-03 23:42 ` Jakub Kicinski
2025-09-04 7:16 ` Alexandra Winter
2025-09-04 15:59 ` Jakub Kicinski [this message]
2025-09-01 14:58 ` [PATCH net-next 2/2] net/smc: Improve log message for devices w/o pnetid Alexandra Winter
2025-09-02 8:54 ` Simon Horman
2025-09-04 16:00 ` [PATCH net-next 0/2] net/smc and s390/ism: Improve log messages patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250904085906.46d9bfe0@kernel.org \
--to=kuba@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=alibuda@linux.alibaba.com \
--cc=andrew+netdev@lunn.ch \
--cc=aswin@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=dust.li@linux.alibaba.com \
--cc=edumazet@google.com \
--cc=gor@linux.ibm.com \
--cc=guwen@linux.alibaba.com \
--cc=hca@linux.ibm.com \
--cc=horms@kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjambigi@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sidraya@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=tonylu@linux.alibaba.com \
--cc=wenjia@linux.ibm.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.