From: Jakub Kicinski <kuba@kernel.org>
To: Sebastian Basierski <sebastian.basierski@intel.com>
Cc: Konrad Leszczynski <konrad.leszczynski@intel.com>,
<davem@davemloft.net>, <andrew+netdev@lunn.ch>,
<edumazet@google.com>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<cezary.rojewski@intel.com>,
Karol Jurczenia <karol.jurczenia@intel.com>
Subject: Re: [PATCH net 3/3] net: stmmac: check if interface is running before TC block setup
Date: Thu, 4 Sep 2025 18:56:28 -0700 [thread overview]
Message-ID: <20250904185628.0de3c483@kernel.org> (raw)
In-Reply-To: <e1e9c67e-04c7-4db4-9719-25e5d0609490@intel.com>
On Thu, 4 Sep 2025 21:01:49 +0200 Sebastian Basierski wrote:
> On 9/1/2025 10:03 PM, Jakub Kicinski wrote:
> > More context would be useful. What's the user-visible behavior before
> > and after? Can the device handle installing the filters while down?
> > Is it just an issue of us restarting the queues when we shouldn't?
>
> Before this patch driver couldn't be unloaded with tc filter applied.
>
> Running those commands is enough to reproduce the issue:
> tc qdisc add dev enp0s29f2 ingress
> tc filter add dev enp0s29f2 ingress protocol all prio 1 u32
> rmmod dwmac_intel
>
> in effect module would not unload.
Makes sense. Could you also confirm that the offload doesn't in fact
work if set up when device is down? I think block setup is when qdisc
is installed?
ip link set dev $x down
tc qdisc add dev enp0s29f2 ingress
ip link set dev $x up
tc filter add dev enp0s29f2 ingress protocol all prio 1 u32 ...
If it doesn't work we can feel safe we're not breaking anyone's
scripts, however questionable.
next prev parent reply other threads:[~2025-09-05 1:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 10:02 [PATCH net 0/3] net: stmmac: misc fixes Konrad Leszczynski
2025-08-28 10:02 ` [PATCH net 1/3] net: stmmac: replace memcpy with strscpy in ethtool Konrad Leszczynski
2025-08-28 13:29 ` Vadim Fedorenko
2025-09-01 19:59 ` Jakub Kicinski
2025-09-04 18:53 ` Sebastian Basierski
2025-09-04 19:18 ` Andrew Lunn
2025-09-15 13:18 ` Konrad Leszczynski
2025-08-28 10:02 ` [PATCH net 2/3] net: stmmac: correct Tx descriptors debugfs prints Konrad Leszczynski
2025-08-28 13:34 ` Vadim Fedorenko
2025-09-01 20:01 ` Jakub Kicinski
2025-09-04 18:54 ` Sebastian Basierski
2025-09-15 12:54 ` Konrad Leszczynski
2025-09-15 15:05 ` Jakub Kicinski
2025-08-28 10:02 ` [PATCH net 3/3] net: stmmac: check if interface is running before TC block setup Konrad Leszczynski
2025-08-28 13:39 ` Vadim Fedorenko
2025-09-01 20:03 ` Jakub Kicinski
2025-09-04 19:01 ` Sebastian Basierski
2025-09-05 1:56 ` Jakub Kicinski [this message]
2025-09-09 18:47 ` Sebastian Basierski
2025-09-16 23:29 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250904185628.0de3c483@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=cezary.rojewski@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=karol.jurczenia@intel.com \
--cc=konrad.leszczynski@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sebastian.basierski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.