From: Peter Foley <pefoley@google.com>
To: qemu-devel@nongnu.org
Cc: Christian Schoenebeck <qemu_oss@crudebyte.com>,
Greg Kurz <groug@kaod.org>,
pbonzini@redhat.com, nabihestefan@google.com,
Peter Foley <pefoley@google.com>
Subject: [PATCH v2] 9pfs: Stop including gstrfuncs.h
Date: Fri, 05 Sep 2025 11:17:11 -0400 [thread overview]
Message-ID: <20250905-9p-v2-1-2ad31999684d@google.com> (raw)
gstrfuncs.h is not intended to be included directly.
In fact this only works because glib.h is already included by osdep.h.
Just remove the include.
Signed-off-by: Peter Foley <pefoley@google.com>
---
Changes in v2:
- Just remove the include entirely in favor of osdep.h
- Link to v1: https://lore.kernel.org/qemu-devel/20250904-9p-v1-1-e634cb374c80@google.com
---
hw/9pfs/9p-util-generic.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/9pfs/9p-util-generic.c b/hw/9pfs/9p-util-generic.c
index 4c1e9c887d00c44bc073bec00c07ed09d3868bf5..b71fa2cb3785349c6b4d2b9591f5ea4f917844d0 100644
--- a/hw/9pfs/9p-util-generic.c
+++ b/hw/9pfs/9p-util-generic.c
@@ -2,7 +2,6 @@
#include "qemu/osdep.h"
#include "9p-util.h"
-#include <glib/gstrfuncs.h>
char *qemu_open_flags_tostr(int flags)
{
---
base-commit: baa79455fa92984ff0f4b9ae94bed66823177a27
change-id: 20250904-9p-11c0405ae7c5
Best regards,
--
Peter Foley <pefoley@google.com>
next reply other threads:[~2025-09-05 15:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 15:17 Peter Foley [this message]
2025-09-06 3:55 ` [PATCH v2] 9pfs: Stop including gstrfuncs.h Richard Henderson
2025-09-08 16:15 ` Christian Schoenebeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250905-9p-v2-1-2ad31999684d@google.com \
--to=pefoley@google.com \
--cc=groug@kaod.org \
--cc=nabihestefan@google.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.