From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13131CA1015 for ; Fri, 5 Sep 2025 09:20:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7AC4510EB3E; Fri, 5 Sep 2025 09:19:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="rVXX+Cah"; dkim-atps=neutral Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) by gabe.freedesktop.org (Postfix) with ESMTPS id B898410EB3E for ; Fri, 5 Sep 2025 09:19:57 +0000 (UTC) Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id EB52E1A0DC3; Fri, 5 Sep 2025 09:19:55 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id C21166060B; Fri, 5 Sep 2025 09:19:55 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id D4479102F092F; Fri, 5 Sep 2025 11:19:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1757063995; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=LgBs42CIazNh/2eGWXx8+IMogL0WEdssecS9MfHXtUI=; b=rVXX+CahxWnEzIHhQQytAoa/bQvj9xtiqGj8TaCCYhxpt++XFrnKRhYDMQ3bJ0fe77dzO2 O9gP5CpjQA3CbtnuA/6rE6AwpwRYvz9nXXZ8QUfxE3lRLNmw2lPYN2YeZyA1QKm+d6JG1+ VnYc2QH9WSXoqDt/jTbMIrKCPtXke9Xi+IyLLDYzPcWicoLeK6y/G6IkJoCg2sQmDNzlRE 5Vnwlwk1UdZbVG8Eb7GLel9iz6lwynfu/7tvPikOFPfHyJWOE9qC4LzQGSCp/pQzc067cj k9LCQo3ObByyGL0jcWlLokiVJpM2mL3/FSR6tiKUTCchRg1cAQL7UaqhHowgaw== Date: Fri, 5 Sep 2025 11:19:40 +0200 From: Luca Ceresoli To: Maxime Ripard Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 01/37] drm/atomic: Convert drm_atomic_get_connector_state() to use new connector state Message-ID: <20250905111940.3c149d99@booty> In-Reply-To: <20250902-drm-no-more-existing-state-v2-1-de98fc5f6d66@kernel.org> References: <20250902-drm-no-more-existing-state-v2-0-de98fc5f6d66@kernel.org> <20250902-drm-no-more-existing-state-v2-1-de98fc5f6d66@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 02 Sep 2025 11:35:00 +0200 Maxime Ripard wrote: > The drm_atomic_get_connector_state() function calls a hand-rolled > implementation of the deprecated > drm_atomic_get_existing_connector_state() helper to get find if a > connector state had already been allocated and was part of the given > drm_atomic_state. > > At the point in time where drm_atomic_get_connector_state() can be > called (ie, during atomic_check), the existing state is the new state > and drm_atomic_get_existing_connector_state() can thus be replaced by > drm_atomic_get_new_connector_state(). > > Signed-off-by: Maxime Ripard Reviewed-by: Luca Ceresoli Tested-by: Luca Ceresoli # on imx8mp -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com