From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 591CACA0FED for ; Fri, 5 Sep 2025 12:22:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 1521E40AAD; Fri, 5 Sep 2025 12:22:48 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id YpbUeMYlsJE9; Fri, 5 Sep 2025 12:22:46 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 49C5140B9F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1757074966; bh=oOPw9vOcSGUEXa2DyzLqTmniom/cTqjWeocxyQYN50g=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=tKVF1BUlqEQ02CC8nHytUoLnS7o39XZ1gax84KaFr8m9StFiLf4o3pFzM8+dP71yU lCaSYaGMocvalmZ/RMvjrkUGdDqJTyN1Mp0pzWB7xDqBOhUDQFlCvbQ8x0JT3nN7d9 RSbyFgmcfa+4cPHD9QJgoW/DIzcGQU6pBU+MQRUL2SXi+zs2sBp0E9ARg9GD5clMzO 55Jy7BfvQ0cf3mIAeeSqrcWHIU+yKSrZ3rh4f3hW/IryhQ3ORs23s7bgqng0HNTKIJ ZVdhgwyvlhFUbnnFawQgz2N0RpLLnXncq3C7dgrGGILqaqk1i+iU/JNzmd95yOnbRS weYMu6tijVbPw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 49C5140B9F; Fri, 5 Sep 2025 12:22:46 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists1.osuosl.org (Postfix) with ESMTP id 369DE1E04 for ; Fri, 5 Sep 2025 12:22:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 284F8405F3 for ; Fri, 5 Sep 2025 12:22:45 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id SpP454gQbJ9m for ; Fri, 5 Sep 2025 12:22:44 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 2D010405E4 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 2D010405E4 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by smtp2.osuosl.org (Postfix) with ESMTPS id 2D010405E4 for ; Fri, 5 Sep 2025 12:22:43 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 6E67360280; Fri, 5 Sep 2025 12:22:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C858C4CEF1; Fri, 5 Sep 2025 12:22:40 +0000 (UTC) Date: Fri, 5 Sep 2025 13:22:38 +0100 From: Simon Horman To: mheib@redhat.com Cc: intel-wired-lan@lists.osuosl.org, przemyslawx.patynowski@intel.com, jiri@resnulli.us, netdev@vger.kernel.org, jacob.e.keller@intel.com, aleksandr.loktionov@intel.com, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com Message-ID: <20250905122238.GA553991@horms.kernel.org> References: <20250903214305.57724-1-mheib@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250903214305.57724-1-mheib@redhat.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757074962; bh=/mm/vrMlSexYGeq/0pE3zP6vvAMX18pTZ5LKa/xIF1U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nyEWSaDEluAd4Ot+nHPqlV2zu8xDWh1Inrht4eb2A1cQs7ff5Cd/sO+fdEuX8pPWx BAnJuYEHv+rncK7YEwsbAEsCSZ8cenb/lxgEJHzpKKgIAqVj2wNvbkwMxcjdvBm5Ob B7JvnI+cTrr6ScmCjF8ZGqeFurOzIoBnu6AlfXy9deE99uVBjto3leUg38wu2ZiSBl 74mB10R9rrjmrnJ8OZdVvLctDLjfs+8k2IVmYM0Vt64YuCdhaGC0gAm7wmvYn+eV32 ZeULtUqllzNrXnLXElWVloCuz/KK/WUgHysE6cebgKiJn6dqWh7wHVDG1n/x4+pb0t aCtMEdZ9nobaw== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=nyEWSaDE Subject: Re: [Intel-wired-lan] [PATCH net-next, v3, 1/2] devlink: Add new "max_mac_per_vf" generic device param X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, Sep 04, 2025 at 12:43:04AM +0300, mheib@redhat.com wrote: > From: Mohammad Heib > > Add a new device generic parameter to controls the maximum > number of MAC filters allowed per VF. > > For example, to limit a VF to 3 MAC addresses: > $ devlink dev param set pci/0000:3b:00.0 name max_mac_per_vf \ > value 3 \ > cmode runtime > > Signed-off-by: Mohammad Heib Overall this looks good to me, thanks. Reviewed-by: Simon Horman One point: This patch-set applies cleanly to iwl but not net-next. If it is to be picked up by Tony and go via the iwl tree, then all good on my side. But if it is targeted at net-next then you'll need to rebase and repost. ... From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F9AF34DCD4 for ; Fri, 5 Sep 2025 12:22:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757074962; cv=none; b=MlrhtionNmdjMYsrsdieCPPsFHbfL7V791ZBEMmPSeCZoF+O78tYIw1yV4S0c5A7h7RabHnooOz0bFQYOoypc4YdgtQ1mRRjXeYWtqfxNs4x+3YNXCRttvTHpP1NcEAjo2/mlkJG21AyvMPxS+fOUdgSlGuHSZGkPYxhxq6Mq6I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757074962; c=relaxed/simple; bh=/mm/vrMlSexYGeq/0pE3zP6vvAMX18pTZ5LKa/xIF1U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XGqKp4viZUjjlmWvqDWBnVy1jc18iFmYRZ3ppEyIACbOYfumNvT4zec99aYqLeJUI3GklEaR8sdPPl1Y/DCqlgUdfl0n6/mOKq4sOsB7THANW2x0v2XyR9AvIh9XRmYsSvL62J3GIaDcPhGwvmymO+9TKVJsjFGieT0ic/RkKBc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nyEWSaDE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nyEWSaDE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C858C4CEF1; Fri, 5 Sep 2025 12:22:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757074962; bh=/mm/vrMlSexYGeq/0pE3zP6vvAMX18pTZ5LKa/xIF1U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nyEWSaDEluAd4Ot+nHPqlV2zu8xDWh1Inrht4eb2A1cQs7ff5Cd/sO+fdEuX8pPWx BAnJuYEHv+rncK7YEwsbAEsCSZ8cenb/lxgEJHzpKKgIAqVj2wNvbkwMxcjdvBm5Ob B7JvnI+cTrr6ScmCjF8ZGqeFurOzIoBnu6AlfXy9deE99uVBjto3leUg38wu2ZiSBl 74mB10R9rrjmrnJ8OZdVvLctDLjfs+8k2IVmYM0Vt64YuCdhaGC0gAm7wmvYn+eV32 ZeULtUqllzNrXnLXElWVloCuz/KK/WUgHysE6cebgKiJn6dqWh7wHVDG1n/x4+pb0t aCtMEdZ9nobaw== Date: Fri, 5 Sep 2025 13:22:38 +0100 From: Simon Horman To: mheib@redhat.com Cc: intel-wired-lan@lists.osuosl.org, przemyslawx.patynowski@intel.com, jiri@resnulli.us, netdev@vger.kernel.org, jacob.e.keller@intel.com, aleksandr.loktionov@intel.com, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com Subject: Re: [PATCH net-next,v3,1/2] devlink: Add new "max_mac_per_vf" generic device param Message-ID: <20250905122238.GA553991@horms.kernel.org> References: <20250903214305.57724-1-mheib@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250903214305.57724-1-mheib@redhat.com> On Thu, Sep 04, 2025 at 12:43:04AM +0300, mheib@redhat.com wrote: > From: Mohammad Heib > > Add a new device generic parameter to controls the maximum > number of MAC filters allowed per VF. > > For example, to limit a VF to 3 MAC addresses: > $ devlink dev param set pci/0000:3b:00.0 name max_mac_per_vf \ > value 3 \ > cmode runtime > > Signed-off-by: Mohammad Heib Overall this looks good to me, thanks. Reviewed-by: Simon Horman One point: This patch-set applies cleanly to iwl but not net-next. If it is to be picked up by Tony and go via the iwl tree, then all good on my side. But if it is targeted at net-next then you'll need to rebase and repost. ...