Re: [yocto-patches] [meta-rockchip][PATCH 2/2] nanopi-r4s: enable r8169 built-in

[Trevor Woerner <twoerner@gmail.com>]

On Fri 2025-09-05 @ 11:10:45 AM, Quentin Schulz via lists.yoctoproject.org wrote:
> Hi Trevor,
> 
> On 9/4/25 9:45 PM, Trevor Woerner via lists.yoctoproject.org wrote:
> > Since the Realtek RTL8169 is part of this board, enable it unconditionally in
> 
> The FriendlyElec wiki and product page doesn't mention this part number,
> weird (but armbian and openwrt forums do).

...and so does the output of lspci.

> FYI, it seems the default value when using "defconfig" defconfig from
> upstream is R8169 driver built as a module, so you could simply install the
> kernel module instead of marking it as Y. (But then you hit some corner
> cases when you want to use NFS for rootfs for example).

Exactly. If it is a device that is built into the board, I think it should be
built into the kernel rather than a module.

I didn't provide this in the commit message, but while testing with it enabled
as a module, it is the driver that is installed automatically by the system,
that's how/why I chose this driver to convert to =y.

> While many devices supported by this driver seem to require (?) a firmware,
> the R8169 seemingly doesn't seem to require one, so I guess this is fine :)
> 
> > the kernel.
> > 
> > Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> 
> Acked-by: Quentin Schulz <quentin.schulz@cherry.de>
> 
> Thanks!
> Quentin
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#2138): https://lists.yoctoproject.org/g/yocto-patches/message/2138
> Mute This Topic: https://lists.yoctoproject.org/mt/115070708/900817
> Group Owner: yocto-patches+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/yocto-patches/leave/13168745/900817/63955952/xyzzy [twoerner@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 
>