Re: [QEMU- PATCH 1/1] cxl_type3: fix segfault in cxl_destroy_dc_regions

[Jonathan Cameron <jonathan.cameron@huawei.com>]

On Thu,  4 Sep 2025 10:02:22 +0100
Joshua Lant <joshualant@googlemail.com> wrote:

> CXL_TYPE3_CLASS() should be CXL_TYPE3_GET_CLASS() given object (CXLType3Dev)
> input. Leads to segfault in object_class_dynamic_cast.
> 
> Fixes: ef730035567
> 
> signed-off-by: Joshua Lant <joshualant@gmail.com>

Good find.

The Fixes tag needs fixing though.
Should be all part of the tags block and needs to include the patch name.
I'm not finding the SHA though.

I think that tag is probably Svetley's MHD callback patch which isn't upstream
so I'll squash this in my local tree and it will be fixed in the next tree
I put up on gitlab.com/jic23/

Thanks,

Jonathan




> ---
>  hw/mem/cxl_type3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/mem/cxl_type3.c b/hw/mem/cxl_type3.c
> index c4658e0955..14cb09d9fe 100644
> --- a/hw/mem/cxl_type3.c
> +++ b/hw/mem/cxl_type3.c
> @@ -919,7 +919,7 @@ static void cxl_destroy_dc_regions(CXLType3Dev *ct3d)
>  {
>      CXLDCExtent *ent, *ent_next;
>      CXLDCExtentGroup *group, *group_next;
> -    CXLType3Class *cvc = CXL_TYPE3_CLASS(ct3d);
> +    CXLType3Class *cvc = CXL_TYPE3_GET_CLASS(ct3d);
>      int i;
>      CXLDCRegion *region;
>