From: Jakub Kicinski <kuba@kernel.org>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Donald Hunter <donald.hunter@gmail.com>,
Simon Horman <horms@kernel.org>,
Jacob Keller <jacob.e.keller@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
wireguard@lists.zx2c4.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 03/11] tools: ynl-gen: add sub-type check
Date: Fri, 5 Sep 2025 17:12:04 -0700 [thread overview]
Message-ID: <20250905171204.483b5f4f@kernel.org> (raw)
In-Reply-To: <20250904220156.1006541-3-ast@fiberby.net>
On Thu, 4 Sep 2025 22:01:26 +0000 Asbjørn Sloth Tønnesen wrote:
> Add a check to verify that the sub-type is "nest", and throw an
> exception if no policy could be generated, as a guard to prevent
> against generating a bad policy.
>
> This is a trivial patch with no behavioural changes intended.
I _think_ the expectation was that one of the other methods which
validate the types more thoroughly has to be called if this one is.
But either way:
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2025-09-06 0:12 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 22:01 [PATCH net-next 00/11] tools: ynl: prepare for wireguard Asbjørn Sloth Tønnesen
2025-09-04 22:01 ` [PATCH net-next 01/11] tools: ynl-gen: allow overriding name-prefix for constants Asbjørn Sloth Tønnesen
2025-09-05 10:36 ` Donald Hunter
2025-09-06 0:07 ` Jakub Kicinski
2025-09-06 0:15 ` Jacob Keller
2025-09-04 22:01 ` [PATCH net-next 02/11] tools: ynl-gen: generate nested array policies Asbjørn Sloth Tønnesen
2025-09-05 10:37 ` Donald Hunter
2025-09-06 0:09 ` Jakub Kicinski
2025-09-06 0:19 ` Jacob Keller
2025-09-06 14:13 ` Asbjørn Sloth Tønnesen
2025-09-08 7:54 ` Johannes Berg
2025-09-08 9:08 ` Asbjørn Sloth Tønnesen
2025-09-08 13:22 ` Johannes Berg
2025-09-09 23:02 ` Jacob Keller
2025-09-04 22:01 ` [PATCH net-next 03/11] tools: ynl-gen: add sub-type check Asbjørn Sloth Tønnesen
2025-09-05 10:37 ` Donald Hunter
2025-09-06 0:12 ` Jakub Kicinski [this message]
2025-09-06 0:20 ` Jacob Keller
2025-09-04 22:01 ` [PATCH net-next 04/11] tools: ynl-gen: define count iterator in print_dump() Asbjørn Sloth Tønnesen
2025-09-05 10:37 ` Donald Hunter
2025-09-06 0:13 ` Jakub Kicinski
2025-09-06 0:20 ` Jacob Keller
2025-09-04 22:01 ` [PATCH net-next 05/11] tools: ynl-gen: define nlattr *array in a block scope Asbjørn Sloth Tønnesen
2025-09-05 10:44 ` Donald Hunter
2025-09-06 0:18 ` Jakub Kicinski
2025-09-06 13:13 ` Asbjørn Sloth Tønnesen
2025-09-06 19:07 ` Jakub Kicinski
2025-09-11 0:01 ` Asbjørn Sloth Tønnesen
2025-09-11 0:27 ` Jakub Kicinski
2025-09-04 22:01 ` [PATCH net-next 06/11] tools: ynl-gen: don't validate nested array attribute types Asbjørn Sloth Tønnesen
2025-09-06 0:23 ` Jakub Kicinski
2025-09-06 13:22 ` Asbjørn Sloth Tønnesen
2025-09-06 19:29 ` Jakub Kicinski
2025-09-06 0:24 ` Jacob Keller
2025-09-06 15:10 ` Asbjørn Sloth Tønnesen
2025-09-08 7:55 ` Johannes Berg
2025-09-10 16:58 ` Jacob Keller
2025-09-04 22:01 ` [PATCH net-next 07/11] tools: ynl-gen: rename TypeArrayNest to TypeIndexedArray Asbjørn Sloth Tønnesen
2025-09-05 10:44 ` Donald Hunter
2025-09-06 0:25 ` Jakub Kicinski
2025-09-04 22:01 ` [PATCH net-next 08/11] tools: ynl: move nest packing to a helper function Asbjørn Sloth Tønnesen
2025-09-05 10:45 ` Donald Hunter
2025-09-04 22:01 ` [PATCH net-next 09/11] tools: ynl: encode indexed-array Asbjørn Sloth Tønnesen
2025-09-05 10:49 ` Donald Hunter
2025-09-05 15:34 ` Asbjørn Sloth Tønnesen
2025-09-04 22:01 ` [PATCH net-next 10/11] tools: ynl: decode hex input Asbjørn Sloth Tønnesen
2025-09-05 10:51 ` Donald Hunter
2025-09-06 0:27 ` Jacob Keller
2025-09-06 14:31 ` Asbjørn Sloth Tønnesen
2025-09-08 8:28 ` Donald Hunter
2025-09-09 18:10 ` Sabrina Dubroca
2025-09-09 20:18 ` Asbjørn Sloth Tønnesen
2025-09-04 22:01 ` [PATCH net-next 11/11] tools: ynl: add ipv4-or-v6 display hint Asbjørn Sloth Tønnesen
2025-09-05 10:53 ` Donald Hunter
2025-09-06 15:59 ` Asbjørn Sloth Tønnesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250905171204.483b5f4f@kernel.org \
--to=kuba@kernel.org \
--cc=Jason@zx2c4.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@fiberby.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.