All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Kevin Tian <kevin.tian@intel.com>, Jann Horn <jannh@google.com>,
	Vasant Hegde <vasant.hegde@amd.com>,
	Dave Hansen <dave.hansen@intel.com>,
	Alistair Popple <apopple@nvidia.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Uladzislau Rezki <urezki@gmail.com>,
	Jean-Philippe Brucker <jean-philippe@linaro.org>,
	Andy Lutomirski <luto@kernel.org>, Yi Lai <yi1.lai@intel.com>,
	iommu@lists.linux.dev, security@kernel.org,
	linux-kernel@vger.kernel.org,
	Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v4 6/8] mm: Introduce deferred freeing for kernel page tables
Date: Fri, 5 Sep 2025 15:43:55 -0300	[thread overview]
Message-ID: <20250905184355.GR616306@nvidia.com> (raw)
In-Reply-To: <20250905055103.3821518-7-baolu.lu@linux.intel.com>

On Fri, Sep 05, 2025 at 01:51:01PM +0800, Lu Baolu wrote:

> +#ifdef CONFIG_ASYNC_PGTABLE_FREE
> +void pagetable_free_async(struct ptdesc *pt);
> +#else
> +static inline void pagetable_free_async(struct ptdesc *pt)
> +{
> +	__pagetable_free(pt);
> +}
> +#endif

I'd probably call this function pagetable_free_kernel() ? Weird to
call it async when it isn't async..

ptdesc_clear_kernel()?

> +	list_for_each_entry_safe(pt, next, &page_list, pt_list) {
> +		list_del(&pt->pt_list);

The list_del isn't necessary, it doesn't zero the list, just _safe
iteration is fine.

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason

  reply	other threads:[~2025-09-05 18:43 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-05  5:50 [PATCH v4 0/8] Fix stale IOTLB entries for kernel address space Lu Baolu
2025-09-05  5:50 ` [PATCH v4 1/8] mm: Add a ptdesc flag to mark kernel page tables Lu Baolu
2025-09-05 18:24   ` Jason Gunthorpe
2025-09-12  7:58   ` Tian, Kevin
2025-09-05  5:50 ` [PATCH v4 2/8] mm: Actually mark kernel page table pages Lu Baolu
2025-09-05 18:24   ` Jason Gunthorpe
2025-09-12  7:59   ` Tian, Kevin
2025-09-05  5:50 ` [PATCH v4 3/8] x86/mm: Use 'ptdesc' when freeing PMD pages Lu Baolu
2025-09-05 18:25   ` Jason Gunthorpe
2025-09-12  8:03   ` Tian, Kevin
2025-09-05  5:50 ` [PATCH v4 4/8] mm: Introduce pure page table freeing function Lu Baolu
2025-09-05 18:31   ` Jason Gunthorpe
2025-09-12  8:04   ` Tian, Kevin
2025-09-05  5:51 ` [PATCH v4 5/8] x86/mm: Use pagetable_free() Lu Baolu
2025-09-05 18:41   ` Jason Gunthorpe
2025-09-05 19:22     ` Dave Hansen
2025-09-05 20:11     ` Dave Hansen
2025-09-05 23:04       ` Jason Gunthorpe
2025-09-19  5:31       ` Baolu Lu
2025-09-05  5:51 ` [PATCH v4 6/8] mm: Introduce deferred freeing for kernel page tables Lu Baolu
2025-09-05 18:43   ` Jason Gunthorpe [this message]
2025-09-05 19:26     ` Dave Hansen
2025-09-12  8:17     ` Tian, Kevin
2025-09-15 11:35       ` Jason Gunthorpe
2025-09-19  8:18         ` Tian, Kevin
2025-09-12  8:14   ` Tian, Kevin
2025-09-15  1:16     ` Baolu Lu
2025-09-05  5:51 ` [PATCH v4 7/8] mm: Hook up Kconfig options for async page table freeing Lu Baolu
2025-09-05 18:44   ` Jason Gunthorpe
2025-09-12  8:19   ` Tian, Kevin
2025-09-05  5:51 ` [PATCH v4 8/8] iommu/sva: Invalidate stale IOTLB entries for kernel address space Lu Baolu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250905184355.GR616306@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=apopple@nvidia.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=iommu@lists.linux.dev \
    --cc=jannh@google.com \
    --cc=jean-philippe@linaro.org \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=peterz@infradead.org \
    --cc=robin.murphy@arm.com \
    --cc=security@kernel.org \
    --cc=urezki@gmail.com \
    --cc=vasant.hegde@amd.com \
    --cc=will@kernel.org \
    --cc=yi1.lai@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.