From: Jakub Kicinski <kuba@kernel.org>
To: Shenwei Wang <shenwei.wang@nxp.com>
Cc: Wei Fang <wei.fang@nxp.com>, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Clark Wang <xiaoning.wang@nxp.com>,
Stanislav Fomichev <sdf@fomichev.me>,
imx@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-imx@nxp.com,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v5 net-next 1/5] net: fec: use a member variable for maximum buffer size
Date: Fri, 5 Sep 2025 18:49:57 -0700 [thread overview]
Message-ID: <20250905184957.76eb37e4@kernel.org> (raw)
In-Reply-To: <20250904203502.403058-2-shenwei.wang@nxp.com>
On Thu, 4 Sep 2025 15:34:58 -0500 Shenwei Wang wrote:
> -#define OPT_FRAME_SIZE (PKT_MAXBUF_SIZE << 16)
> +#define OPT_FRAME_SIZE (fep->max_buf_size << 16)
Please don't implicitly depend on local variables with a certain name.
It's quite bad code hygiene. Looks like this define is only used once
so perhaps you should instead create a define like
#define OPT_ARCH_NEEDS_BUFSZ
And then use that in fec_restart() to either add
(fep->max_buf_size << 16)
to rcntl or not?
--
pw-bot: cr
next prev parent reply other threads:[~2025-09-06 1:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 20:34 [PATCH v5 net-next 0/5] net: fec: add the Jumbo frame support Shenwei Wang
2025-09-04 20:34 ` [PATCH v5 net-next 1/5] net: fec: use a member variable for maximum buffer size Shenwei Wang
2025-09-04 21:02 ` Frank Li
2025-09-06 1:49 ` Jakub Kicinski [this message]
2025-09-04 20:34 ` [PATCH v5 net-next 2/5] net: fec: add pagepool_order to support variable page size Shenwei Wang
2025-09-04 21:03 ` Frank Li
2025-09-06 1:52 ` Jakub Kicinski
2025-09-04 20:35 ` [PATCH v5 net-next 3/5] net: fec: add rx_frame_size to support configurable RX length Shenwei Wang
2025-09-04 21:13 ` Frank Li
2025-09-04 20:35 ` [PATCH v5 net-next 4/5] net: fec: add change_mtu to support dynamic buffer allocation Shenwei Wang
2025-09-04 21:37 ` Frank Li
2025-09-06 1:56 ` Jakub Kicinski
2025-09-04 20:35 ` [PATCH v5 net-next 5/5] net: fec: enable the Jumbo frame support for i.MX8QM Shenwei Wang
2025-09-04 21:40 ` Frank Li
2025-09-05 20:14 ` Shenwei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250905184957.76eb37e4@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=imx@lists.linux.dev \
--cc=john.fastabend@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.