From: Nathan Chancellor <nathan@kernel.org>
To: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Cc: Borislav Petkov <bp@alien8.de>,
kernel test robot <oliver.sang@intel.com>,
Borislav Petkov <bp@kernel.org>,
oe-lkp@lists.linux.dev, lkp@intel.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, X86 ML <x86@kernel.org>,
"Chang S. Bae" <chang.seok.bae@intel.com>,
Sohil Mehta <sohil.mehta@intel.com>,
linux-nilfs@vger.kernel.org
Subject: Re: [PATCH -v1 1/2] x86/microcode: Add microcode= cmdline parsing
Date: Fri, 5 Sep 2025 12:27:22 -0700 [thread overview]
Message-ID: <20250905192722.GA1274334@ax162> (raw)
In-Reply-To: <CAKFNMo=QxweJwTxf-ubYfmBVYBpNEennGLFLRxqhB+evre7zhw@mail.gmail.com>
On Fri, Sep 05, 2025 at 10:17:26PM +0900, Ryusuke Konishi wrote:
> Thank you very much, Nathan, for sharing your detailed report and
> proposing a fix.
>
> I actually performed a reproduction test in an environment with
> CONFIG_LTO_CLANG_THIN=y and confirmed that the CFI panic reoccurs, and
> that your patch fixes it.
>
> I also followed your analysis of sysfs and concluded that it is
> correct and that your changes to the two
> nilfs_feature_{revision,README}_show() functions are necessary. I'll
> check whether these were necessary from the beginning or whether they
> became necessary later.
>
> I'd like to send your proposed fixes upstream, but could you please
> send it to me and linux-nilfs in the form of a proper patch? (I'll
> need at least your SoB line).
Thanks for taking a look and confirming :) I have sent a patch with a
proper changelog along for you to take a look at.
https://lore.kernel.org/20250905-nilfs2-fix-features-cfi-violation-v1-1-b5d35136d813@kernel.org/
From what I can tell, this has always been wrong, hence that Fixes tag
but if you disagree, feel free to update it!
Cheers,
Nathan
next prev parent reply other threads:[~2025-09-05 19:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 13:50 [PATCH -v1 0/2] x86/microcode: Add debugging glue Borislav Petkov
2025-08-20 13:50 ` [PATCH -v1 1/2] x86/microcode: Add microcode= cmdline parsing Borislav Petkov
2025-08-21 5:03 ` Sohil Mehta
2025-08-21 5:15 ` Chang S. Bae
2025-09-02 8:45 ` kernel test robot
2025-09-04 11:37 ` Borislav Petkov
2025-09-04 23:29 ` Nathan Chancellor
2025-09-05 10:40 ` Borislav Petkov
2025-09-05 13:17 ` Ryusuke Konishi
2025-09-05 19:27 ` Nathan Chancellor [this message]
2025-09-05 10:30 ` [tip: x86/microcode] " tip-bot2 for Borislav Petkov (AMD)
2025-08-20 13:50 ` [PATCH -v1 2/2] x86/microcode: Add microcode loader debugging functionality Borislav Petkov
2025-08-20 15:35 ` Nikolay Borisov
2025-08-20 15:56 ` Borislav Petkov
2025-08-21 5:19 ` Sohil Mehta
2025-08-29 9:45 ` Borislav Petkov
2025-08-29 23:25 ` Sohil Mehta
2025-08-30 9:25 ` Borislav Petkov
2025-09-05 10:30 ` [tip: x86/microcode] " tip-bot2 for Borislav Petkov (AMD)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250905192722.GA1274334@ax162 \
--to=nathan@kernel.org \
--cc=bp@alien8.de \
--cc=bp@kernel.org \
--cc=chang.seok.bae@intel.com \
--cc=konishi.ryusuke@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=sohil.mehta@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.