From: Greg KH <gregkh@linuxfoundation.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Jens Axboe <axboe@kernel.dk>,
Caleb Sander Mateos <csander@purestorage.com>,
io-uring <io-uring@vger.kernel.org>,
workflows@vger.kernel.org
Subject: Re: Link trailers revisited (was Re: [GIT PULL] io_uring fix for 6.17-rc5)
Date: Sat, 6 Sep 2025 13:30:36 +0200 [thread overview]
Message-ID: <2025090605-evidence-chomp-d442@gregkh> (raw)
In-Reply-To: <2025090633-calcium-legroom-586f@gregkh>
On Sat, Sep 06, 2025 at 01:27:57PM +0200, Greg KH wrote:
> On Sat, Sep 06, 2025 at 01:27:04PM +0200, Greg KH wrote:
> > On Fri, Sep 05, 2025 at 03:33:14PM -0400, Konstantin Ryabitsev wrote:
> > > (Changing the subject and aiming this at workflows.)
> > >
> > > On Fri, Sep 05, 2025 at 11:06:01AM -0700, Linus Torvalds wrote:
> > > > On Fri, 5 Sept 2025 at 10:45, Konstantin Ryabitsev
> > > > <konstantin@linuxfoundation.org> wrote:
> > > > >
> > > > > Do you just want this to become a no-op, or will it be better if it's used
> > > > > only with the patch.msgid.link domain namespace to clearly indicate that it's
> > > > > just a provenance link?
> > > >
> > > > So I wish it at least had some way to discourage the normal mindless
> > > > use - and in a perfect world that there was some more useful model for
> > > > adding links automatically.
> > > >
> > > > For example, I feel like for the cover letter of a multi-commit
> > > > series, the link to the patch series submission is potentially more
> > > > useful - and likely much less annoying - because it would go into the
> > > > merge message, not individual commits.
> > >
> > > We do support this usage using `b4 shazam -M` -- it's the functional
> > > equivalent of applying a pull request and will use the cover letter contents
> > > as the initial source of the merge commit message. I do encourage people to
> > > use this more than just a linear `git am` for series, for a number of reasons:
> > >
> > > - this clearly delineates the start and end of the series
> > > - this incorporates the contents cover letter that can give more info about
> > > the series than just individual commits *without* the need to hit the lore
> > > archive
> > > - this lets maintainers record any additional thoughts they may have in the
> > > merge commit, alongside with the original cover letter
> > >
> > > Obviously, we don't want to use the cover letter as-is, which is why b4 will
> > > open the configured editor to let the maintainer pulling in the series make
> > > any changes to the cover letter before it becomes the merge commit.
> >
> > I like this a lot, and just tried it, but it ends up applying the
> > patches from the list without my signed-off-by, which will cause
> > linux-next to complain when it sees that I committed patches without
> > that.
> >
> > Did I miss an option to `b4 shazam`? Does it need to add a -s option
> > like `b4 am` has?
>
> Oh nevermind, it does support -s. It's just not documented :)
>
> let me go make a patch...
And it is documented. Ugh, nevermind, I need more coffee, sorry for the
noise.
next prev parent reply other threads:[~2025-09-06 11:30 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 11:18 [GIT PULL] io_uring fix for 6.17-rc5 Jens Axboe
2025-09-05 17:24 ` Linus Torvalds
2025-09-05 17:45 ` Konstantin Ryabitsev
2025-09-05 18:06 ` Linus Torvalds
2025-09-05 19:33 ` Link trailers revisited (was Re: [GIT PULL] io_uring fix for 6.17-rc5) Konstantin Ryabitsev
2025-09-05 20:09 ` Linus Torvalds
2025-09-05 20:47 ` Sasha Levin
2025-09-06 11:27 ` Greg KH
2025-09-06 11:27 ` Greg KH
2025-09-06 11:30 ` Greg KH [this message]
2025-09-06 13:51 ` Konstantin Ryabitsev
2025-09-06 15:31 ` Linus Torvalds
2025-09-06 18:50 ` Konstantin Ryabitsev
2025-09-06 19:19 ` Linus Torvalds
2025-09-08 9:11 ` Jani Nikula
2025-09-08 11:59 ` Mark Brown
2025-09-08 20:11 ` dan.j.williams
2025-09-09 11:29 ` Mark Brown
2025-09-09 13:17 ` Rafael J. Wysocki
2025-09-09 14:18 ` Jakub Kicinski
2025-09-09 14:35 ` Jens Axboe
2025-09-09 14:42 ` Konstantin Ryabitsev
2025-09-09 14:48 ` Vlastimil Babka
2025-09-09 14:50 ` Jens Axboe
2025-09-09 15:30 ` Rafael J. Wysocki
2025-09-09 16:40 ` Linus Torvalds
2025-09-09 17:08 ` Mark Brown
2025-09-09 17:50 ` Linus Torvalds
2025-09-09 17:58 ` Linus Torvalds
2025-09-09 18:31 ` Konstantin Ryabitsev
2025-09-09 19:36 ` dan.j.williams
2025-09-10 1:12 ` dan.j.williams
2025-09-10 12:19 ` Mark Brown
2025-09-09 17:25 ` dan.j.williams
2025-09-09 17:56 ` Alexei Starovoitov
2025-09-09 18:01 ` Linus Torvalds
2025-09-09 18:13 ` Alexei Starovoitov
2025-09-09 18:06 ` Vlastimil Babka
2025-09-09 18:14 ` Linus Torvalds
2025-09-09 18:22 ` Vlastimil Babka
2025-09-09 21:05 ` Mark Brown
2025-09-10 1:33 ` Konstantin Ryabitsev
2025-09-09 14:44 ` Greg KH
2025-09-09 15:14 ` Danilo Krummrich
2025-09-09 16:32 ` [RFC] b4 dig: Add AI-powered email relationship discovery command Sasha Levin
2025-09-09 17:22 ` Laurent Pinchart
2025-09-09 17:26 ` Jens Axboe
2025-09-09 18:54 ` Sasha Levin
2025-09-10 10:13 ` Laurent Pinchart
2025-09-10 10:55 ` Sasha Levin
2025-09-10 11:29 ` Laurent Pinchart
2025-09-10 13:38 ` Konstantin Ryabitsev
2025-09-10 14:03 ` Andrew Dona-Couch
2025-09-11 14:48 ` Nicolas Frattaroli
2025-09-11 15:05 ` Sasha Levin
2025-09-11 19:13 ` Nicolas Frattaroli
2025-09-11 19:57 ` Sasha Levin
2025-09-15 11:26 ` Mark Brown
2025-09-15 11:48 ` Sasha Levin
2025-09-15 12:03 ` Mark Brown
2025-09-11 23:24 ` Konstantin Ryabitsev
2025-09-07 22:04 ` [GIT PULL] io_uring fix for 6.17-rc5 Jonathan Corbet
2025-09-05 19:04 ` Jens Axboe
2025-09-05 19:07 ` Jens Axboe
2025-09-05 19:13 ` Caleb Sander Mateos
2025-09-05 19:16 ` Jens Axboe
2025-09-05 19:15 ` Linus Torvalds
2025-09-05 19:23 ` Jens Axboe
2025-09-05 19:21 ` Linus Torvalds
2025-09-05 19:30 ` Jens Axboe
2025-09-05 20:54 ` Linus Torvalds
2025-09-06 0:01 ` Jens Axboe
2025-09-07 18:47 ` Jonathan Corbet
2025-09-08 22:15 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025090605-evidence-chomp-d442@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=io-uring@vger.kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=torvalds@linux-foundation.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.