Re: [PATCH v2 18/22] phy: apple: Add Apple Type-C PHY

[kernel test robot <lkp@intel.com>]

Hi Sven,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 8f5ae30d69d7543eee0d70083daf4de8fe15d585]

url:    https://github.com/intel-lab-lkp/linux/commits/Sven-Peter/dt-bindings-usb-Add-Apple-dwc3/20250906-234603
base:   8f5ae30d69d7543eee0d70083daf4de8fe15d585
patch link:    https://lore.kernel.org/r/20250906-atcphy-6-17-v2-18-52c348623ef6%40kernel.org
patch subject: [PATCH v2 18/22] phy: apple: Add Apple Type-C PHY
config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20250907/202509072156.F8s3V9JA-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 7fb1dc08d2f025aad5777bb779dfac1197e9ef87)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250907/202509072156.F8s3V9JA-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509072156.F8s3V9JA-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/phy/apple/atc.c:2108:11: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
    2108 |                         return ret;
         |                                ^~~
   drivers/phy/apple/atc.c:2086:9: note: initialize the variable 'ret' to silence this warning
    2086 |         int ret;
         |                ^
         |                 = 0
   1 warning generated.


vim +/ret +2108 drivers/phy/apple/atc.c

  2083	
  2084	static int atcphy_load_tunables(struct apple_atcphy *atcphy)
  2085	{
  2086		int ret;
  2087		struct {
  2088			const char *dt_name;
  2089			struct apple_tunable **tunable;
  2090		} tunables[] = {
  2091			{ "apple,tunable-fuses", &atcphy->tunables.fuses },
  2092			{ "apple,tunable-axi2af", &atcphy->tunables.axi2af },
  2093			{ "apple,tunable-common", &atcphy->tunables.common },
  2094			{ "apple,tunable-lane0-usb", &atcphy->tunables.lane_usb3[0] },
  2095			{ "apple,tunable-lane1-usb", &atcphy->tunables.lane_usb3[1] },
  2096			{ "apple,tunable-lane0-cio", &atcphy->tunables.lane_usb4[0] },
  2097			{ "apple,tunable-lane1-cio", &atcphy->tunables.lane_usb4[1] },
  2098			{ "apple,tunable-lane0-dp", &atcphy->tunables.lane_displayport[0] },
  2099			{ "apple,tunable-lane1-dp", &atcphy->tunables.lane_displayport[1] },
  2100		};
  2101	
  2102		for (int i = 0; i < ARRAY_SIZE(tunables); i++) {
  2103			*tunables[i].tunable =
  2104				devm_apple_tunable_parse(atcphy->dev, atcphy->np, tunables[i].dt_name);
  2105			if (IS_ERR(tunables[i].tunable)) {
  2106				dev_err(atcphy->dev, "Failed to read tunable %s: %ld\n",
  2107					tunables[i].dt_name, PTR_ERR(tunables[i].tunable));
> 2108				return ret;
  2109			}
  2110		}
  2111	
  2112		return 0;
  2113	}
  2114	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki