From: Jakub Kicinski <kuba@kernel.org>
To: Conley Lee <conleylee@foxmail.com>, vkoul@kernel.org
Cc: davem@davemloft.net, wens@csie.org, mripard@kernel.org,
netdev@vger.kernel.org, dmaengine@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: sun4i-emac: free dma descriptor
Date: Mon, 8 Sep 2025 13:26:15 -0700 [thread overview]
Message-ID: <20250908132615.6a2507ed@kernel.org> (raw)
In-Reply-To: <tencent_D434891410B0717BB0BDCB1434969E6EB50A@qq.com>
On Sun, 7 Sep 2025 19:29:30 +0800 Conley Lee wrote:
> In the current implementation of the sun4i-emac driver, when using DMA to
> receive data packets, the descriptor for the current DMA request is not
> released in the rx_done_callback.
I wish you elaborated more on the reuse flag not being set :\
> Fix this by properly releasing the descriptor.
>
> Fixes: 47869e82c8b8 ("sun4i-emac.c: add dma support")
> Signed-off-by: Conley Lee <conleylee@foxmail.com>
Hi Vinod, could you TAL? Is this fix legit or there's something wrong
with how the DMA engine API is used on this platform?
https://lore.kernel.org/all/tencent_D434891410B0717BB0BDCB1434969E6EB50A@qq.com/
next prev parent reply other threads:[~2025-09-08 20:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-30 7:49 [PATCH 1/2] net: ethernet: sun4i-emac: free dma desc Conley Lee
2025-09-02 22:57 ` Jakub Kicinski
2025-09-03 7:49 ` [PATCH] net: ethernet: sun4i-emac: free dma descriptor Conley Lee
2025-09-04 14:24 ` Jakub Kicinski
2025-09-07 11:29 ` Conley Lee
2025-09-08 20:26 ` Jakub Kicinski [this message]
2025-09-09 6:36 ` 李克斯
2025-09-10 1:15 ` Jakub Kicinski
2025-09-10 10:42 ` Conley Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250908132615.6a2507ed@kernel.org \
--to=kuba@kernel.org \
--cc=conleylee@foxmail.com \
--cc=davem@davemloft.net \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vkoul@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.