From: Jakub Kicinski <kuba@kernel.org>
To: Nai-Chen Cheng <bleach1827@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH] selftests/net: fix unused return value warnings in ksft.h
Date: Mon, 8 Sep 2025 18:20:18 -0700 [thread overview]
Message-ID: <20250908182018.28d9ff10@kernel.org> (raw)
In-Reply-To: <20250906-selftests-net-ksft-v1-1-f1577cea3f68@gmail.com>
On Sat, 06 Sep 2025 23:59:28 +0800 Nai-Chen Cheng wrote:
> The write() and read() system calls in ksft_ready() and ksft_wait()
> functions return values that were not being checked, causing complier
> warnings with GCC.
Is it just a GCC warning or rather a combination of GCC and some
misguided glibc decorator to force check the return of read/write?
Naming the compiler versions and the warning flag which enables
this would be useful. We don't see it building with normal warning
level today.
> Fix the warnings by casting the return values to void to indicate that
> ignoring them is intentional.
> ret = read(fd, &byte, sizeof(byte));
> (void)ret;
Can you not cast the read() to void directly?
--
pw-bot: cr
next prev parent reply other threads:[~2025-09-09 1:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-06 15:59 [PATCH] selftests/net: fix unused return value warnings in ksft.h Nai-Chen Cheng
2025-09-09 1:20 ` Jakub Kicinski [this message]
2025-09-09 10:00 ` Nai-Chen(Simone) Cheng
2025-09-09 23:25 ` Jakub Kicinski
2025-09-10 11:16 ` Nai-Chen(Simone) Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250908182018.28d9ff10@kernel.org \
--to=kuba@kernel.org \
--cc=bleach1827@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.