All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Petr Machata <petrm@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, <netdev@vger.kernel.org>,
	Simon Horman <horms@kernel.org>,
	Nikolay Aleksandrov <razor@blackwall.org>,
	Ido Schimmel <idosch@nvidia.com>, <bridge@lists.linux.dev>,
	<mlxsw@nvidia.com>, Vladimir Oltean <vladimir.oltean@nxp.com>,
	Andrew Lunn <andrew@lunn.ch>, Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH net-next 00/10] bridge: Allow keeping local FDB entries only on VLAN 0
Date: Mon, 8 Sep 2025 19:27:53 -0700	[thread overview]
Message-ID: <20250908192753.7bdb8d21@kernel.org> (raw)
In-Reply-To: <cover.1757004393.git.petrm@nvidia.com>

On Thu, 4 Sep 2025 19:07:17 +0200 Petr Machata wrote:
> Yet another option might be to use in-kernel FDB filtering, and to filter
> the local entries when dumping. Unfortunately, this does not help all that
> much either, because the linked-list walk still needs to happen. Also, with
> the obvious filtering interface built around ndm_flags / ndm_state
> filtering, one can't just exclude pure local entries in one query. One
> needs to dump all non-local entries first, and then to get permanent
> entries in another run filter local & added_by_user. I.e. one needs to pay
> the iteration overhead twice, and then integrate the result in userspace.
> To get significant savings, one would need a very specific knob like "dump,
> but skip/only include local entries". But if we are adding a local-specific
> knobs, maybe let's have an option to just not duplicate them in the first
> place.

Local-specific knob for dump seems like the most direct way to address
your concern, if I'm reading the cover letter right. Also, is it normal
to special case vlan 0 the way this series does? Wouldn't it be cleaner
to store local entries in a separate hash table? Perhaps if they lived
in a separate hash table it'd be odd to dump them for VLAN 0 (so the
series also conflates the kernel internals and control path/dump output)

Given that Nik has authored the previous version a third opinion would
be great... adding a handful of people to CC.

  parent reply	other threads:[~2025-09-09  2:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-04 17:07 [PATCH net-next 00/10] bridge: Allow keeping local FDB entries only on VLAN 0 Petr Machata
2025-09-04 17:07 ` [PATCH net-next 01/10] net: bridge: Introduce BROPT_FDB_LOCAL_VLAN_0 Petr Machata
2025-09-04 17:07 ` [PATCH net-next 02/10] net: bridge: BROPT_FDB_LOCAL_VLAN_0: Look up FDB on VLAN 0 on miss Petr Machata
2025-09-09  2:15   ` Jakub Kicinski
2025-09-09 13:34     ` Petr Machata
2025-09-04 17:07 ` [PATCH net-next 03/10] net: bridge: BROPT_FDB_LOCAL_VLAN_0: On port changeaddr, skip per-VLAN FDBs Petr Machata
2025-09-04 17:07 ` [PATCH net-next 04/10] net: bridge: BROPT_FDB_LOCAL_VLAN_0: On bridge " Petr Machata
2025-09-04 17:07 ` [PATCH net-next 05/10] net: bridge: BROPT_FDB_LOCAL_VLAN_0: Skip local FDBs on VLAN creation Petr Machata
2025-09-04 17:07 ` [PATCH net-next 06/10] net: bridge: Introduce UAPI for BR_BOOLOPT_FDB_LOCAL_VLAN_0 Petr Machata
2025-09-04 17:07 ` [PATCH net-next 07/10] selftests: defer: Allow spaces in arguments of deferred commands Petr Machata
2025-09-04 17:07 ` [PATCH net-next 08/10] selftests: defer: Introduce DEFER_PAUSE_ON_FAIL Petr Machata
2025-09-04 17:07 ` [PATCH net-next 09/10] selftests: net: lib.sh: Don't defer failed commands Petr Machata
2025-09-04 17:07 ` [PATCH net-next 10/10] selftests: forwarding: Add test for BR_BOOLOPT_FDB_LOCAL_VLAN_0 Petr Machata
2025-09-06 18:16 ` [PATCH net-next 00/10] bridge: Allow keeping local FDB entries only on VLAN 0 Nikolay Aleksandrov
2025-09-09  2:27 ` Jakub Kicinski [this message]
2025-09-09  9:07   ` Nikolay Aleksandrov
2025-09-09  9:19     ` Nikolay Aleksandrov
2025-10-04 13:19     ` Linus Lüssing
2025-10-04 14:31       ` Nikolay Aleksandrov
2025-09-09 12:12   ` Petr Machata
2025-09-12  2:05 ` Jakub Kicinski
2025-09-12  2:10 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250908192753.7bdb8d21@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=bridge@lists.linux.dev \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=jiri@resnulli.us \
    --cc=mlxsw@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=razor@blackwall.org \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.