From: Jakub Kicinski <kuba@kernel.org>
To: Bhargava Marreddy <bhargava.marreddy@broadcom.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, michael.chan@broadcom.com,
pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com,
Vikas Gupta <vikas.gupta@broadcom.com>,
Rajashekar Hudumula <rajashekar.hudumula@broadcom.com>
Subject: Re: [v6, net-next 02/10] bng_en: Add initial support for RX and TX rings
Date: Mon, 8 Sep 2025 19:39:11 -0700 [thread overview]
Message-ID: <20250908193911.21bbdc2c@kernel.org> (raw)
In-Reply-To: <20250905224652.48692-3-bhargava.marreddy@broadcom.com>
On Fri, 5 Sep 2025 22:46:44 +0000 Bhargava Marreddy wrote:
> +static int bnge_alloc_rx_rings(struct bnge_net *bn)
> +{
> + int i, rc = 0, agg_rings = 0, cpu;
> + struct bnge_dev *bd = bn->bd;
> +
> + if (!bn->rx_ring)
> + return -ENOMEM;
Why would rx_ring not be set at this stage?
Please avoid defensive programming.
next prev parent reply other threads:[~2025-09-09 2:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 22:46 [v6, net-next 00/10] Add more functionality to BNGE Bhargava Marreddy
2025-09-05 22:18 ` Jakub Kicinski
2025-09-08 12:17 ` Bhargava Chenna Marreddy
2025-09-05 22:46 ` [v6, net-next 01/10] bng_en: make bnge_alloc_ring() self-unwind on failure Bhargava Marreddy
2025-09-05 22:46 ` [v6, net-next 02/10] bng_en: Add initial support for RX and TX rings Bhargava Marreddy
2025-09-09 2:39 ` Jakub Kicinski [this message]
2025-09-05 22:46 ` [v6, net-next 03/10] bng_en: Add initial support for CP and NQ rings Bhargava Marreddy
2025-09-05 22:46 ` [v6, net-next 04/10] bng_en: Introduce VNIC Bhargava Marreddy
2025-09-05 22:46 ` [v6, net-next 05/10] bng_en: Initialise core resources Bhargava Marreddy
2025-09-05 22:46 ` [v6, net-next 06/10] bng_en: Allocate packet buffers Bhargava Marreddy
2025-09-05 22:46 ` [v6, net-next 07/10] bng_en: Allocate stat contexts Bhargava Marreddy
2025-09-09 2:39 ` Jakub Kicinski
2025-09-05 22:46 ` [v6, net-next 08/10] bng_en: Register rings with the firmware Bhargava Marreddy
2025-09-05 22:46 ` [v6, net-next 09/10] bng_en: Register default VNIC Bhargava Marreddy
2025-09-05 22:46 ` [v6, net-next 10/10] bng_en: Configure " Bhargava Marreddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250908193911.21bbdc2c@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bhargava.marreddy@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=rajashekar.hudumula@broadcom.com \
--cc=vikas.gupta@broadcom.com \
--cc=vsrama-krishna.nemani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.