From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D3D7CAC586 for ; Mon, 8 Sep 2025 12:44:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4743E10E50A; Mon, 8 Sep 2025 12:44:11 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="fcWN17ce"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 63CA110E49F; Mon, 8 Sep 2025 09:19:35 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 20E7D60052; Mon, 8 Sep 2025 09:19:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 403A1C4CEF1; Mon, 8 Sep 2025 09:19:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1757323174; bh=djpAvoW8u0704b3oCV7FoPkRvtuc1IaqNChDWkioAgU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fcWN17ceIcjLaoFIMu7BW8j7N6aCbAyD0tzxQ2/zL9QllPAU+C2j0edPPXXeYF9wD j05L9/lmUombWtgzQys5J0K7QYXMbupcLWWyciQ3NwOznXntp/DvdmvEn8laqFKnB1 eAzUFOIGG7fAuEN3pmIdQqI77eMV6TvrYvVKPa40= Date: Mon, 8 Sep 2025 11:19:31 +0200 From: Greg Kroah-Hartman To: "Mario Limonciello (AMD)" Cc: "Rafael J . Wysocki" , Danilo Krummrich , Bjorn Helgaas , Pavel Machek , Len Brown , Christian =?iso-8859-1?Q?K=F6nig?= , "James E . J . Bottomley" , "Martin K . Petersen" , Steven Rostedt , "open list:HIBERNATION (aka Software Suspend, aka swsusp)" , "open list:RADEON and AMDGPU DRM DRIVERS" , "open list:DRM DRIVERS" , "open list:PCI SUBSYSTEM" , "open list:SCSI SUBSYSTEM" , "open list:USB SUBSYSTEM" , "open list:TRACING" , AceLan Kao , Kai-Heng Feng , Mark Pearson , Merthan =?utf-8?Q?Karaka=C5=9F?= , Eric Naim Subject: Re: [PATCH v6 RESEND 00/11] Improvements to S5 power consumption Message-ID: <2025090852-coma-tycoon-9f37@gregkh> References: <20250906143642.2590808-1-superm1@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250906143642.2590808-1-superm1@kernel.org> X-Mailman-Approved-At: Mon, 08 Sep 2025 12:44:10 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Sat, Sep 06, 2025 at 09:36:31AM -0500, Mario Limonciello (AMD) wrote: > A variety of issues both in function and in power consumption have been > raised as a result of devices not being put into a low power state when > the system is powered off. > > There have been some localized changes[1] to PCI core to help these issues, > but they have had various downsides. > > This series instead tries to use the S4 flow when the system is being > powered off. This lines up the behavior with what other operating systems > do as well. If for some reason that fails or is not supported, run their > shutdown() callbacks. > > Cc: AceLan Kao > Cc: Kai-Heng Feng > Cc: Mark Pearson > Cc: Merthan Karakaş > Cc: Eric Naim > --- > v6 RESEND: > * Resent because Greg said he was ignoring it and would like the whole > series to be able to review. Messy, but wow, I'll trust you all that this actually works properly. No objections from me, but I don't want my ack on this as I don't know how to maintain it :) thanks, greg k-h