Re: [PATCH v3 5/8] mmc: sdhci: add Black Sesame Technologies BST C1200 controller driver

[Albert Yang <yangzh0906@thundersoft.com>]

On Mon, Aug 18, 2025 at 12:48:39PM +0200, Ulf Hansson wrote:
> On Tue, 12 Aug 2025 at 14:31, Albert Yang <yangzh0906@thundersoft.com> wrote:
> >

> > +               timeout = 20;
> > +               while (!((clk = sdhci_readw(host, SDHCI_CLOCK_CONTROL)) &
> > +                       SDHCI_CLOCK_INT_STABLE)) {
> > +                       if (timeout == 0) {
> > +                               dev_err(mmc_dev(host->mmc), "Internal clock never stabilised\n");
> > +                               return -EBUSY;
> > +                       }
> > +                       timeout--;
> > +                       usleep_range(1000, 1100);
> > +               }
>
> Please convert into using some of the readx_poll_timeout functions
> instead of the loop above. Moreover, please add defines to specify the
> period/timeout.
>

> > +       while (!((clk = sdhci_readw(host, SDHCI_CLOCK_CONTROL)) &
> > +               SDHCI_CLOCK_INT_STABLE)) {
> > +               if (timeout == 0) {
> > +                       dev_err(mmc_dev(host->mmc), "Internal clock never stabilised\n");
> > +                       return -EBUSY;
> > +               }
> > +               timeout--;
> > +               usleep_range(1000, 1100);
> > +       }
>
> Ditto.
>

Thanks for the review. I have created a new static function as suggested:

static int sdhci_bst_wait_int_clk(struct sdhci_host *host)
{
	u16 clk;

	if (read_poll_timeout(sdhci_readw, clk, (clk & SDHCI_CLOCK_INT_STABLE),
			BST_CLK_STABLE_POLL_US, BST_CLK_STABLE_TIMEOUT_US, false,
			host, SDHCI_CLOCK_CONTROL))
		return -EBUSY;
	return 0;
}

And I will replace the code at the call sites with the following:

		if (sdhci_bst_wait_int_clk(host)) {
			dev_err(mmc_dev(host->mmc), "Internal clock never stabilised\n");
			return -EBUSY;
		}


Best Regards,
Albert