Re: [PATCH] net: atlantic: make RX page order tunable via module param

[Simon Horman <horms@kernel.org>]

On Tue, Sep 09, 2025 at 10:13:17AM +0100, Simon Horman wrote:
> On Sat, Sep 06, 2025 at 09:54:34PM +0800, Yangyu Chen wrote:

...

> > diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
> > index b24eaa5283fa..48f35fbf9a70 100644
> > --- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
> > +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
> > @@ -40,6 +40,10 @@ static unsigned int aq_itr_rx;
> >  module_param_named(aq_itr_rx, aq_itr_rx, uint, 0644);
> >  MODULE_PARM_DESC(aq_itr_rx, "RX interrupt throttle rate");
> >  
> > +static unsigned int rxpageorder = AQ_CFG_RX_PAGEORDER;
> > +module_param_named(rxpageorder, rxpageorder, uint, 0644);
> > +MODULE_PARM_DESC(rxpageorder, "RX page order");
> > +
> 
> Unfortunately adding new module parameters to networking drivers
> is strongly discouraged. Can we find another way to address the problem
> described in your cover: e.g.
> 
> 1. Changing the fixed value
> 2. Somehow making the value auto detected
> 3. Some other mechanism to allow the user to configure the value, e.g. devlink
> 
> ...

Oops. I now see that Andrew and Jakub already responded.
And my comment doesn't add much. Sorry about that.