From: Simon Horman <horms@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, shuah@kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next] selftests: net: speed up pmtu.sh by avoiding unnecessary cleanup
Date: Tue, 9 Sep 2025 10:24:41 +0100 [thread overview]
Message-ID: <20250909092441.GG2015@horms.kernel.org> (raw)
In-Reply-To: <20250906214535.3204785-1-kuba@kernel.org>
On Sat, Sep 06, 2025 at 02:45:35PM -0700, Jakub Kicinski wrote:
> The pmtu test takes nearly an hour when run on a debug kernel
> (10min on a normal kernel, so the debug slow down is quite significant).
> NIPA tries to ensure all results are delivered by a certain deadline
> so this prevents it from retrying the test in case of a flake.
>
> Looks like one of the slowest operations in the test is calling out
> to ./openvswitch/ovs-dpctl.py to remove potential leftover OvS interfaces.
> Check whether the interfaces exist in the first place in sysfs,
> since it can be done directly in bash it is very fast.
>
> This should save us around 20-30% of the test runtime.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
It would be interesting to know why this is so slow.
But I agree that avoiding unnecessary work is a good approach
if it is slow. And that appears to be the case.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-09-09 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-06 21:45 [PATCH net-next] selftests: net: speed up pmtu.sh by avoiding unnecessary cleanup Jakub Kicinski
2025-09-09 9:24 ` Simon Horman [this message]
2025-09-09 23:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250909092441.GG2015@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.