From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B7ACCAC583 for ; Tue, 9 Sep 2025 13:28:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2456D81D16; Tue, 9 Sep 2025 13:28:16 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id R7fLes_KJ6Hj; Tue, 9 Sep 2025 13:28:14 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org C38628144A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1757424494; bh=lOFbe0vR6czp0/eqbrG1Wb24maTnVEBLDSjkaHmaFxE=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=lj9Jfemk6Z3wzbUMvfDUKmZHKV1RRk5oWVarSlY40E++IX0Q3PEzbEjzaoGLkOw5u 39+zdcVO2doxzl36DKw+Z0FfKritjqVbY8O6jfmpsrjSYMr3dBJSZ3yJbsZYYCezc0 r1O9Hv6KP7Qcr4dxS27d4wtRzoDOEeeitQJUe2/rfzcxtQODkzoP4/yP45iRsC2ndK otGurvjuSVxT4PvlutCdTjPEMEP/F3oTpTqqlAa+KQY/c+8ysvlVlNH/vQ6DOkz2sp +SP1tQPB0ZiiHRSEe3g7Kks4CVsg8JUjaJjA2UyWw0KeEw8er9s2li3gNA04+FEDMM mzw1KX0YwQ/hw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id C38628144A; Tue, 9 Sep 2025 13:28:14 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists1.osuosl.org (Postfix) with ESMTP id 1BD67CA for ; Tue, 9 Sep 2025 13:28:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 0252F401A1 for ; Tue, 9 Sep 2025 13:28:13 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Uc8LNQmlYMXT for ; Tue, 9 Sep 2025 13:28:12 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=leon@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 458224018D DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 458224018D Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) by smtp2.osuosl.org (Postfix) with ESMTPS id 458224018D for ; Tue, 9 Sep 2025 13:28:12 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 93D7440951; Tue, 9 Sep 2025 13:28:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0751AC4CEF4; Tue, 9 Sep 2025 13:28:10 +0000 (UTC) Date: Tue, 9 Sep 2025 15:20:51 +0300 From: Leon Romanovsky To: Tatyana Nikolova , jiri@resnulli.us Cc: intel-wired-lan@lists.osuosl.org, przemyslaw.kitszel@intel.com, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, anthony.l.nguyen@intel.com Message-ID: <20250909122051.GF341237@unreal> References: <20250904195719.371-1-tatyana.e.nikolova@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250904195719.371-1-tatyana.e.nikolova@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757424491; bh=VMUJFmLcsKGBDDr5v9bXqubrob3qdBOhonNwTJDZQaU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H+yZ20h0+Dby0VNZESEZBL1k7vPh7lZAT5v4K0c7BYWTYEGfVNgf/a0zNMA6fDYlQ +zZ615z4LihhDOJuqLi1RmI4Exu0DZwTcYrIzjOwNjkRxJP166fiFYjsOj/hvkZUY2 Batn+CgQKCn1AOsrK/I+qFkx8HvulAqoi5DYjTnWrIRKxMgyu83yQa6drOdCHLMtyb k5HZPEnsBVqhixIqIPzP5DrZgyfJbIzCi1UX28MjOyeHr67pOwrC83QV11iSMiBAgw c/0Fnqo1X1teBFuFGJPXN19nFNh8koJxx134game4/7YsbmO16fcp62PFVwYlbMXIl HdbUsYstHAdSg== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=H+yZ20h0 Subject: Re: [Intel-wired-lan] [iwl-next] ice, irdma: Add rdma_qp_limits_sel devlink parameter for irdma X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, Sep 04, 2025 at 02:57:19PM -0500, Tatyana Nikolova wrote: > Add a devlink parameter to switch between different QP resource profiles > (max number of QPs) supported by irdma for Intel Ethernet 800 devices. The > rdma_qp_limits_sel is translated into an index in the rsrc_limits_table to > select a power of two number between 1 and 256 for max supported QPs (1K-256K). > To reduce the irdma memory footprint, set the rdma_qp_limits_sel default value > to 1 (max 1K QPs). > > Reviewed-by: Przemek Kitszel > Signed-off-by: Tatyana Nikolova > --- > Since the changes to irdma are minor, this is targeted to iwl-next/net-next. <...> > #define DEVLINK_LOCAL_FWD_DISABLED_STR "disabled" > #define DEVLINK_LOCAL_FWD_ENABLED_STR "enabled" > #define DEVLINK_LOCAL_FWD_PRIORITIZED_STR "prioritized" > @@ -1621,6 +1723,7 @@ enum ice_param_id { > ICE_DEVLINK_PARAM_ID_BASE = DEVLINK_PARAM_GENERIC_ID_MAX, > ICE_DEVLINK_PARAM_ID_TX_SCHED_LAYERS, > ICE_DEVLINK_PARAM_ID_LOCAL_FWD, > + ICE_DEVLINK_PARAM_ID_RDMA_QP_LIMITS_SEL, > }; I was under impression that driver-specific devlink knobs are not allowed. Was this limitation changed for Intel? Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9902236435; Tue, 9 Sep 2025 13:28:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757424492; cv=none; b=KA5RCmEg/JuT5p7SbyHGsRMy9oTVJihrM6ieuI+fISnCSDhna4VtJqW5/IUZq4Wm0VtpUYRPhWXvDk2iG3qsgr+F9CzmsJYUDHiARcHQ4r7/lDR7qPnU0YcW5HzUhvNnTPFLM63hkr9dfTIn0NCCxBx9lpjuDHt/Hj93/eI9nf0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757424492; c=relaxed/simple; bh=VMUJFmLcsKGBDDr5v9bXqubrob3qdBOhonNwTJDZQaU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IpHMoocKTXsO8qx7QLozgRhBI6WIMLttL86gU1uuvbJ30iYRENQIUJ0wXAsyqFqfyKAhwGu6xlFdb8uBYRk4+YLNiEJwiBjK2Tv32t1Qv3pvh7xtDquWYQKWBHDSRJYsxepA0aiikY+s+Vg0ZBSL7FmbZcMB4+wnzqAWHY26xwc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=H+yZ20h0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="H+yZ20h0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0751AC4CEF4; Tue, 9 Sep 2025 13:28:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757424491; bh=VMUJFmLcsKGBDDr5v9bXqubrob3qdBOhonNwTJDZQaU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H+yZ20h0+Dby0VNZESEZBL1k7vPh7lZAT5v4K0c7BYWTYEGfVNgf/a0zNMA6fDYlQ +zZ615z4LihhDOJuqLi1RmI4Exu0DZwTcYrIzjOwNjkRxJP166fiFYjsOj/hvkZUY2 Batn+CgQKCn1AOsrK/I+qFkx8HvulAqoi5DYjTnWrIRKxMgyu83yQa6drOdCHLMtyb k5HZPEnsBVqhixIqIPzP5DrZgyfJbIzCi1UX28MjOyeHr67pOwrC83QV11iSMiBAgw c/0Fnqo1X1teBFuFGJPXN19nFNh8koJxx134game4/7YsbmO16fcp62PFVwYlbMXIl HdbUsYstHAdSg== Date: Tue, 9 Sep 2025 15:20:51 +0300 From: Leon Romanovsky To: Tatyana Nikolova , jiri@resnulli.us Cc: intel-wired-lan@lists.osuosl.org, przemyslaw.kitszel@intel.com, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, anthony.l.nguyen@intel.com Subject: Re: [iwl-next] ice, irdma: Add rdma_qp_limits_sel devlink parameter for irdma Message-ID: <20250909122051.GF341237@unreal> References: <20250904195719.371-1-tatyana.e.nikolova@intel.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250904195719.371-1-tatyana.e.nikolova@intel.com> On Thu, Sep 04, 2025 at 02:57:19PM -0500, Tatyana Nikolova wrote: > Add a devlink parameter to switch between different QP resource profiles > (max number of QPs) supported by irdma for Intel Ethernet 800 devices. The > rdma_qp_limits_sel is translated into an index in the rsrc_limits_table to > select a power of two number between 1 and 256 for max supported QPs (1K-256K). > To reduce the irdma memory footprint, set the rdma_qp_limits_sel default value > to 1 (max 1K QPs). > > Reviewed-by: Przemek Kitszel > Signed-off-by: Tatyana Nikolova > --- > Since the changes to irdma are minor, this is targeted to iwl-next/net-next. <...> > #define DEVLINK_LOCAL_FWD_DISABLED_STR "disabled" > #define DEVLINK_LOCAL_FWD_ENABLED_STR "enabled" > #define DEVLINK_LOCAL_FWD_PRIORITIZED_STR "prioritized" > @@ -1621,6 +1723,7 @@ enum ice_param_id { > ICE_DEVLINK_PARAM_ID_BASE = DEVLINK_PARAM_GENERIC_ID_MAX, > ICE_DEVLINK_PARAM_ID_TX_SCHED_LAYERS, > ICE_DEVLINK_PARAM_ID_LOCAL_FWD, > + ICE_DEVLINK_PARAM_ID_RDMA_QP_LIMITS_SEL, > }; I was under impression that driver-specific devlink knobs are not allowed. Was this limitation changed for Intel? Thanks