Re: [PATCH net-next v2 01/11] virtio-pci: Expose generic device capability operations

[Simon Horman <horms@kernel.org>]

On Mon, Sep 08, 2025 at 11:40:36AM -0500, Daniel Jurgens wrote:

...

> diff --git a/include/linux/virtio.h b/include/linux/virtio.h
> index db31fc6f4f1f..a6e121b6f1f1 100644
> --- a/include/linux/virtio.h
> +++ b/include/linux/virtio.h
> @@ -12,6 +12,7 @@
>  #include <linux/dma-mapping.h>
>  #include <linux/completion.h>
>  #include <linux/virtio_features.h>
> +#include <linux/virtio_admin.h>
>  
>  /**
>   * struct virtqueue - a queue to register buffers for sending or receiving.
> @@ -161,6 +162,7 @@ struct virtio_device {
>  	struct virtio_device_id id;
>  	const struct virtio_config_ops *config;
>  	const struct vringh_config_ops *vringh_config;
> +	const struct virtio_admin_ops *admin_ops;

nit: Please consider also adding admin_ops to the Kernel doc for
     struct virtio_device.

>  	struct list_head vqs;
>  	VIRTIO_DECLARE_FEATURES(features);
>  	void *priv;

...