From: Jakub Kicinski <kuba@kernel.org>
To: Matthieu Baerts <matttbe@kernel.org>
Cc: Donald Hunter <donald.hunter@gmail.com>,
Mat Martineau <martineau@kernel.org>,
Geliang Tang <geliang@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Davide Caratti <dcaratti@redhat.com>,
Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, mptcp@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kselftest@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net 1/3] netlink: specs: mptcp: fix if-idx attribute type
Date: Tue, 9 Sep 2025 18:42:21 -0700 [thread overview]
Message-ID: <20250909184221.02b070b0@kernel.org> (raw)
In-Reply-To: <8f0bc70f-1657-4938-88e8-532ffb7c1a12@kernel.org>
On Tue, 9 Sep 2025 11:08:46 +0200 Matthieu Baerts wrote:
> > Note that mptcp_pm_parse_entry has this, which should maybe be fixed at
> > the same time:
> >
> > u32 val = nla_get_s32(tb[MPTCP_PM_ADDR_ATTR_IF_IDX]);
>
> Good catch!
indeed!
> This should be fixed in a dedicated patch, because this fixes commit:
> ef0da3b8a2f1 ("mptcp: move address attribute into mptcp_addr_info"), a
> different commit than the one being fixed here.
int = u32 is unlikely to cause issues AFAIU. We recently applied
a bunch of such fixes to net-next. I think this can also go to -next.
next prev parent reply other threads:[~2025-09-10 1:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 21:27 [PATCH net 0/3] mptcp: misc fixes for v6.17-rc6 Matthieu Baerts (NGI0)
2025-09-08 21:27 ` [PATCH net 1/3] netlink: specs: mptcp: fix if-idx attribute type Matthieu Baerts (NGI0)
2025-09-09 8:44 ` Donald Hunter
2025-09-09 9:08 ` Matthieu Baerts
2025-09-10 1:42 ` Jakub Kicinski [this message]
2025-09-10 8:27 ` Matthieu Baerts
2025-09-08 21:27 ` [PATCH net 2/3] doc: mptcp: net.mptcp.pm_type is deprecated Matthieu Baerts (NGI0)
2025-09-09 19:03 ` Simon Horman
2025-09-08 21:27 ` [PATCH net 3/3] selftests: mptcp: shellcheck: support v0.11.0 Matthieu Baerts (NGI0)
2025-09-09 19:04 ` Simon Horman
2025-09-10 1:50 ` [PATCH net 0/3] mptcp: misc fixes for v6.17-rc6 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250909184221.02b070b0@kernel.org \
--to=kuba@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=horms@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.