Re: [PATCH 1/2] nova-core: Add a library for bitfields in Rust structs

[Joel Fernandes <joelagnelf@nvidia.com>]

On Mon, Aug 25, 2025 at 12:46:18PM +0200, Danilo Krummrich wrote:
> On 8/24/25 3:59 PM, Joel Fernandes wrote:
> > Add a minimal bitfield library for defining in Rust structures (called
> > bitstruct), similar in concept to bit fields in C structs. This will be used
> > for defining page table entries and other structures in nova-core.
> > 
> > Signed-off-by: Joel Fernandes <joelagnelf@nvidia.com>
> > ---
> >   drivers/gpu/nova-core/bitstruct.rs | 149 +++++++++++++++++++++++++++++
> >   drivers/gpu/nova-core/nova_core.rs |   1 +
> >   2 files changed, 150 insertions(+)
> >   create mode 100644 drivers/gpu/nova-core/bitstruct.rs
> 
> I think this is much simpler than the register!() macro that we decided to
> experiment with and work out within nova-core before making it available as
> generic infrastructure.
> 
> So, probably this should go under rust/kernel/ directly.

Ok, yes, for next revision I moved it into rust/kernel/bits/ and register
into rust/kernel/io/.

thanks,

 - Joel