From: Simon Horman <horms@kernel.org>
To: Carolina Jubran <cjubran@nvidia.com>
Cc: Shuah Khan <shuah@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Gal Pressman <gal@nvidia.com>, Tariq Toukan <tariqt@nvidia.com>,
Cosmin Ratiu <cratiu@nvidia.com>, Nimrod Oren <noren@nvidia.com>,
Mark Bloch <mbloch@nvidia.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 net 0/2] selftests: drv-net: Fix issues in devlink_rate_tc_bw.py
Date: Wed, 10 Sep 2025 09:36:49 +0100 [thread overview]
Message-ID: <20250910083649.GI20205@horms.kernel.org> (raw)
In-Reply-To: <20250909101353.3778751-1-cjubran@nvidia.com>
On Tue, Sep 09, 2025 at 01:13:51PM +0300, Carolina Jubran wrote:
> This series fixes issues in devlink_rate_tc_bw.py selftest that made
> its checks unreliable and its documentation inconsistent with the
> actual configuration.
>
> V2:
> - Dropped the patch that relaxed the total bandwidth check. Jakub
> suggested addressing the instability with interval-based measurement
> and by migrating to load.py. That will be handled in a follow-up.
> - Link to V1: https://lore.kernel.org/netdev/20250831080641.1828455-1-cjubran@nvidia.com/
>
> Thanks
>
> Carolina Jubran (2):
> selftests: drv-net: Fix and clarify TC bandwidth split in
> devlink_rate_tc_bw.py
> selftests: drv-net: Fix tolerance calculation in devlink_rate_tc_bw.py
>
> .../drivers/net/hw/devlink_rate_tc_bw.py | 100 ++++++++----------
> 1 file changed, 43 insertions(+), 57 deletions(-)
Hi Carolina,
It isn't strictly related to these changes.
But CI flaggs that devlink_rate_tc_bw.py should
be present in the Makefile for in the same directory.
Given the wildcard in the Makefile I'm unsure if that
is true or not. Could you take a look?
prev parent reply other threads:[~2025-09-10 8:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 10:13 [PATCH v2 net 0/2] selftests: drv-net: Fix issues in devlink_rate_tc_bw.py Carolina Jubran
2025-09-09 10:13 ` [PATCH v2 net 1/2] selftests: drv-net: Fix and clarify TC bandwidth split " Carolina Jubran
2025-09-10 8:34 ` Simon Horman
2025-09-09 10:13 ` [PATCH v2 net 2/2] selftests: drv-net: Fix tolerance calculation " Carolina Jubran
2025-09-10 8:35 ` Simon Horman
2025-09-10 8:36 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250910083649.GI20205@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=cjubran@nvidia.com \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=noren@nvidia.com \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.