From: Jakub Kicinski <kuba@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux.dev, kernel-team@meta.com
Subject: Re: [PATCH net-next 4/7] net: ethtool: add get_rx_ring_count callback to optimize RX ring queries
Date: Wed, 10 Sep 2025 09:10:36 -0700 [thread overview]
Message-ID: <20250910091036.3054eb94@kernel.org> (raw)
In-Reply-To: <20250909-gxrings-v1-4-634282f06a54@debian.org>
On Tue, 09 Sep 2025 13:24:02 -0700 Breno Leitao wrote:
> +static int get_num_rxrings(struct net_device *dev)
ethtool_get_rx_ring_count()
> +{
> + const struct ethtool_ops *ops = dev->ethtool_ops;
> + struct ethtool_rxnfc rx_rings;
You need to initialize this..
> + int ret;
> +
> + if (ops->get_rx_ring_count)
> + return ops->get_rx_ring_count(dev);
> +
> + ret = ops->get_rxnfc(dev, &rx_rings, NULL);
> + if (ret < 0)
> + return ret;
--
pw-bot: cr
next prev parent reply other threads:[~2025-09-10 16:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 20:23 [PATCH net-next 0/7] net: ethtool: add dedicated GRXRINGS driver callbacks Breno Leitao
2025-09-09 20:23 ` [PATCH net-next 1/7] net: ethtool: pass the num of RX rings directly to ethtool_copy_validate_indir Breno Leitao
2025-09-09 20:24 ` [PATCH net-next 2/7] net: ethtool: add support for ETHTOOL_GRXRINGS ioctl Breno Leitao
2025-09-09 20:24 ` [PATCH net-next 3/7] net: ethtool: remove the duplicated handling from ethtool_get_rxrings Breno Leitao
2025-09-09 20:24 ` [PATCH net-next 4/7] net: ethtool: add get_rx_ring_count callback to optimize RX ring queries Breno Leitao
2025-09-10 16:10 ` Jakub Kicinski [this message]
2025-09-09 20:24 ` [PATCH net-next 5/7] net: ethtool: update set_rxfh to use get_num_rxrings helper Breno Leitao
2025-09-09 20:24 ` [PATCH net-next 6/7] net: ethtool: update set_rxfh_indir " Breno Leitao
2025-09-09 20:24 ` [PATCH net-next 7/7] net: virtio_net: add get_rxrings ethtool callback for RX ring queries Breno Leitao
2025-09-11 13:46 ` [PATCH net-next 0/7] net: ethtool: add dedicated GRXRINGS driver callbacks Lei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250910091036.3054eb94@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=horms@kernel.org \
--cc=jasowang@redhat.com \
--cc=kernel-team@meta.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.