All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ryan Zhou <ryanzhou54@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Thinh.Nguyen@synopsys.com, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-usb@vger.kernel.org,
	rafael@kernel.org, royluo@google.com, ryanzhou54@gmail.com,
	stern@rowland.harvard.edu
Subject: [PATCH v3] drvier: usb: dwc3: Fix runtime PM trying to activate child device xxx.dwc3 but parent is not active
Date: Wed, 10 Sep 2025 20:26:30 +0800	[thread overview]
Message-ID: <20250910122630.8435-1-ryanzhou54@gmail.com> (raw)
In-Reply-To: <2025090959-italicize-silly-f628@gregkh>

Issue description:During the wake-up sequence, if the system invokes
 dwc3->resume and detects that the parent device of dwc3 is in a
runtime suspend state, the system will generate an error: runtime PM
trying to activate child device xxx.dwc3 but parent is not active.

Solution:At the dwc3->resume entry point, if the dwc3 controller
is detected in a suspended state, the function shall return
immediately without executing any further operations.

Signed-off-by: Ryan Zhou <ryanzhou54@gmail.com>
---
 drivers/usb/dwc3/core.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 370fc524a468..06a6f8a67129 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -2687,6 +2687,9 @@ int dwc3_pm_resume(struct dwc3 *dwc)
 	struct device *dev = dwc->dev;
 	int		ret = 0;
 
+	if (pm_runtime_suspended(dev))
+		return ret;
+
 	pinctrl_pm_select_default_state(dev);
 
 	pm_runtime_disable(dev);
-- 
2.25.1


  reply	other threads:[~2025-09-10 12:26 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-26 15:08 [PATCH] drvier: usb: dwc3: Fix runtime PM trying to activate child device xxx.dwc3 but parent is not active Ryan Zhou
2025-08-26 18:38 ` Roy Luo
2025-08-27 14:09   ` ryan zhou
2025-08-27 14:52     ` Alan Stern
2025-08-27 18:56       ` Rafael J. Wysocki
2025-08-29  0:43         ` Thinh Nguyen
2025-08-29  1:25           ` Alan Stern
2025-08-29 19:07             ` Thinh Nguyen
2025-08-29 19:26               ` Rafael J. Wysocki
2025-08-29 20:13                 ` Thinh Nguyen
2025-08-30  0:46                   ` Alan Stern
2025-08-30  1:14                     ` Thinh Nguyen
2025-08-29 19:23             ` Rafael J. Wysocki
2025-08-29 19:58               ` Alan Stern
2025-09-01 19:41                 ` Rafael J. Wysocki
2025-09-01 20:40                   ` Rafael J. Wysocki
2025-09-02  2:41                     ` Alan Stern
2025-09-03 11:51                       ` ryan zhou
2025-09-03 19:30                       ` Rafael J. Wysocki
2025-09-03 21:54                         ` Alan Stern
2025-09-04 14:08                           ` Rafael J. Wysocki
2025-09-04 14:19                             ` Alan Stern
2025-09-04 14:33                               ` Rafael J. Wysocki
2025-09-04 17:34                               ` Rafael J. Wysocki
2025-09-04 18:54                                 ` Alan Stern
2025-09-09 16:19                                   ` [PATCH v2] " Ryan Zhou
2025-09-09 16:25                                     ` Greg KH
2025-09-10 12:26                                       ` Ryan Zhou [this message]
2025-09-10 12:56                                       ` ryan zhou
2025-09-10 13:07                                         ` Greg KH
2025-09-11 13:25                                           ` ryan zhou
2025-09-11  1:32                                     ` Thinh Nguyen
2025-09-11 10:52                                       ` Xu Yang
2025-09-11 11:35                                         ` Rafael J. Wysocki
2025-09-11 13:56                                           ` ryan zhou
2025-09-11 13:58                                             ` Rafael J. Wysocki
2025-09-12  7:51                                           ` Xu Yang
2025-09-12 21:38                                             ` Thinh Nguyen
2025-09-11 13:51                                         ` ryan zhou
2025-09-12  7:49                                           ` Xu Yang
2025-09-11 13:40                                       ` ryan zhou
2025-09-12 21:36                                         ` Thinh Nguyen
2025-09-12 22:23                                   ` [PATCH] " Thinh Nguyen
2025-09-13 12:43                                     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250910122630.8435-1-ryanzhou54@gmail.com \
    --to=ryanzhou54@gmail.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=royluo@google.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.