All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net, hawk@kernel.org
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
	andrew+netdev@lunn.ch, horms@kernel.org,
	ilias.apalodimas@linaro.org, nathan@kernel.org,
	nick.desaulniers+lkml@gmail.com, morbo@google.com,
	justinstitt@google.com, llvm@lists.linux.dev
Subject: Re: [PATCH net-next] page_pool: always add GFP_NOWARN for ATOMIC allocations
Date: Wed, 10 Sep 2025 17:52:40 -0700	[thread overview]
Message-ID: <20250910175240.72c56e86@kernel.org> (raw)
In-Reply-To: <20250908152123.97829-1-kuba@kernel.org>

On Mon,  8 Sep 2025 08:21:23 -0700 Jakub Kicinski wrote:
> Driver authors often forget to add GFP_NOWARN for page allocation
> from the datapath. This is annoying to operators as OOMs are a fact
> of life, and we pretty much expect network Rx to hit page allocation
> failures during OOM. Make page pool add GFP_NOWARN for ATOMIC allocations
> by default.

Hi Jesper! Are you okay with this? It's not a lot of instructions and
it's in the _slow() function, anyway. TBH I wrote the patch to fix the
driver (again) first but when writing the commit message I realized my
explanation why we can't fix this in the core was sounding like BS :$

  parent reply	other threads:[~2025-09-11  0:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-08 15:21 [PATCH net-next] page_pool: always add GFP_NOWARN for ATOMIC allocations Jakub Kicinski
2025-09-08 16:15 ` Mina Almasry
2025-09-08 20:20   ` Jakub Kicinski
2025-09-11  0:52 ` Jakub Kicinski [this message]
2025-09-11 13:05   ` Jesper Dangaard Brouer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250910175240.72c56e86@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hawk@kernel.org \
    --cc=horms@kernel.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=justinstitt@google.com \
    --cc=llvm@lists.linux.dev \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nick.desaulniers+lkml@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.