From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, "Hanna Reitz" <hreitz@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Christian Schoenebeck" <qemu_oss@crudebyte.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
"Stefan Weil" <sw@weilnetz.de>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Dr. David Alan Gilbert" <dave@treblig.org>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH v3 01/20] include: define constant for early constructor priority
Date: Wed, 10 Sep 2025 19:03:38 +0100 [thread overview]
Message-ID: <20250910180357.320297-2-berrange@redhat.com> (raw)
In-Reply-To: <20250910180357.320297-1-berrange@redhat.com>
Functions marked with __attribute__((__constructor__)) will be
invoked in linker order. In theory this is well defined, but
in practice, it is hard to determine what this order will be
with the layers of indirection through meson, ninja and the
static libraries QEMU builds.
Notably, the order currently appears different between Linux
and Windows (as tested with Wine on Linux). This can cause
problems when certain QEMU constructors have a dependancy on
other QEMU constructors.
To address this define a QEMU_CONSTRUCTOR_EARLY constant which
provides a priority value that will run before other default
constructors. This is to be used for QEMU constructors that
are themselves self-contained, but may be relied upon by other
constructors.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Dr. David Alan Gilbert <dave@treblig.org>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
include/qemu/compiler.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h
index 1c2b673c05..4c49f52eb0 100644
--- a/include/qemu/compiler.h
+++ b/include/qemu/compiler.h
@@ -194,6 +194,14 @@
# define QEMU_USED
#endif
+/*
+ * A priority for __attribute__((constructor(...))) that
+ * will run earlier than the default constructors. Must
+ * only be used for functions that have no dependency
+ * on global initialization of other QEMU subsystems.
+ */
+#define QEMU_CONSTRUCTOR_EARLY 101
+
/*
* Disable -ftrivial-auto-var-init on a local variable.
*
--
2.50.1
next prev parent reply other threads:[~2025-09-10 18:10 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 18:03 [PATCH v3 00/20] util: sync error_report & qemu_log output more closely Daniel P. Berrangé
2025-09-10 18:03 ` Daniel P. Berrangé [this message]
2025-09-10 18:03 ` [PATCH v3 02/20] monitor: initialize global data from a constructor Daniel P. Berrangé
2025-09-17 14:07 ` Markus Armbruster
2025-09-17 15:31 ` Daniel P. Berrangé
2025-09-18 6:30 ` Markus Armbruster
2025-09-10 18:03 ` [PATCH v3 03/20] system: unconditionally enable thread naming Daniel P. Berrangé
2025-09-11 12:18 ` Ján Tomko
2025-09-19 8:20 ` Markus Armbruster
2025-09-19 13:32 ` Daniel P. Berrangé
2025-09-10 18:03 ` [PATCH v3 04/20] util: expose qemu_thread_set_name Daniel P. Berrangé
2025-09-19 8:39 ` Markus Armbruster
2025-09-24 8:37 ` Daniel P. Berrangé
2025-09-10 18:03 ` [PATCH v3 05/20] audio: make jackaudio use qemu_thread_set_name Daniel P. Berrangé
2025-09-11 13:21 ` Christian Schoenebeck
2025-09-12 14:58 ` Daniel P. Berrangé
2025-09-19 8:46 ` Markus Armbruster
2025-09-10 18:03 ` [PATCH v3 06/20] util: set the name for the 'main' thread Daniel P. Berrangé
2025-09-10 18:03 ` [PATCH v3 07/20] util: add API to fetch the current thread name Daniel P. Berrangé
2025-09-19 8:59 ` Markus Armbruster
2025-09-19 9:05 ` Daniel P. Berrangé
2025-09-19 11:35 ` Markus Armbruster
2025-09-23 12:12 ` Markus Armbruster
2025-09-24 8:55 ` Daniel P. Berrangé
2025-09-10 18:03 ` [PATCH v3 08/20] log: avoid repeated prefix on incremental qemu_log calls Daniel P. Berrangé
2025-09-10 23:20 ` Dr. David Alan Gilbert
2025-09-11 8:49 ` Richard Henderson
2025-09-17 14:11 ` Markus Armbruster
2025-09-17 15:33 ` Daniel P. Berrangé
2025-09-23 12:46 ` Philippe Mathieu-Daudé
2025-09-23 14:28 ` Markus Armbruster
2025-09-23 14:55 ` Daniel P. Berrangé
2025-09-24 7:06 ` Markus Armbruster
2025-09-24 7:12 ` Daniel P. Berrangé
2025-09-24 9:20 ` Daniel P. Berrangé
2025-09-24 12:34 ` Markus Armbruster
2025-09-24 13:30 ` Daniel P. Berrangé
2025-09-10 18:03 ` [PATCH v3 09/20] ui/vnc: remove use of error_printf_unless_qmp() Daniel P. Berrangé
2025-09-11 0:08 ` Dr. David Alan Gilbert
2025-09-11 8:51 ` Richard Henderson
2025-09-11 17:54 ` Richard Henderson
2025-09-12 15:11 ` Daniel P. Berrangé
2025-09-19 11:42 ` Markus Armbruster
2025-09-10 18:03 ` [PATCH v3 10/20] monitor: remove redundant error_[v]printf_unless_qmp Daniel P. Berrangé
2025-09-11 8:50 ` Richard Henderson
2025-09-19 11:42 ` Markus Armbruster
2025-09-23 12:48 ` Philippe Mathieu-Daudé
2025-09-10 18:03 ` [PATCH v3 11/20] monitor: move error_vprintf() back to error-report.c Daniel P. Berrangé
2025-09-11 8:55 ` Richard Henderson
2025-09-19 12:27 ` Markus Armbruster
2025-09-19 13:43 ` Daniel P. Berrangé
2025-09-10 18:03 ` [PATCH v3 12/20] monitor: introduce monitor_cur_hmp() function Daniel P. Berrangé
2025-09-11 17:52 ` Richard Henderson
2025-09-19 12:43 ` Markus Armbruster
2025-09-19 13:29 ` Daniel P. Berrangé
2025-09-20 7:06 ` Markus Armbruster
2025-09-20 11:54 ` Dr. David Alan Gilbert
2025-09-22 8:38 ` Markus Armbruster
2025-09-24 16:09 ` Daniel P. Berrangé
2025-09-10 18:03 ` [PATCH v3 13/20] util: don't skip error prefixes when QMP is active Daniel P. Berrangé
2025-09-22 8:43 ` Markus Armbruster
2025-09-10 18:03 ` [PATCH v3 14/20] util: fix interleaving of error & trace output Daniel P. Berrangé
2025-09-11 18:01 ` Richard Henderson
2025-09-11 18:05 ` Richard Henderson
2025-09-12 16:30 ` Daniel P. Berrangé
2025-09-22 12:16 ` Markus Armbruster
2025-09-10 18:03 ` [PATCH v3 15/20] util: introduce common helper for error-report & log code Daniel P. Berrangé
2025-09-11 18:02 ` Richard Henderson
2025-09-10 18:03 ` [PATCH v3 16/20] util: convert error-report & log to message API for timestamp Daniel P. Berrangé
2025-09-11 18:04 ` Richard Henderson
2025-09-10 18:03 ` [PATCH v3 17/20] util: add support for formatting a workload name in messages Daniel P. Berrangé
2025-09-11 18:06 ` Richard Henderson
2025-09-11 20:27 ` Dr. David Alan Gilbert
2025-09-12 8:34 ` Daniel P. Berrangé
2025-09-12 11:18 ` Dr. David Alan Gilbert
2025-09-10 18:03 ` [PATCH v3 18/20] util: add support for formatting a program " Daniel P. Berrangé
2025-09-11 18:07 ` Richard Henderson
2025-09-11 18:08 ` Richard Henderson
2025-09-12 16:33 ` Daniel P. Berrangé
2025-09-10 18:03 ` [PATCH v3 19/20] util: add support for formatting thread info " Daniel P. Berrangé
2025-09-11 18:11 ` Richard Henderson
2025-09-12 8:36 ` Daniel P. Berrangé
2025-09-10 18:03 ` [PATCH v3 20/20] util: add brackets around guest name in message context Daniel P. Berrangé
2025-09-11 18:12 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250910180357.320297-2-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=dave@treblig.org \
--cc=hreitz@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=richard.henderson@linaro.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.