From: Mateusz Guzik <mjguzik@gmail.com>
To: brauner@kernel.org
Cc: viro@zeniv.linux.org.uk, jack@suse.cz,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
josef@toxicpanda.com, kernel-team@fb.com, amir73il@gmail.com,
linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-xfs@vger.kernel.org, ocfs2-devel@lists.linux.dev,
Mateusz Guzik <mjguzik@gmail.com>
Subject: [PATCH v3 1/4] fs: expand dump_inode()
Date: Thu, 11 Sep 2025 06:55:54 +0200 [thread overview]
Message-ID: <20250911045557.1552002-2-mjguzik@gmail.com> (raw)
In-Reply-To: <20250911045557.1552002-1-mjguzik@gmail.com>
This adds fs name and few fields from struct inode: i_mode, i_opflags,
i_flags and i_state.
All values printed raw, no attempt to pretty-print anything.
Compile tested on for i386 and runtime tested on amd64.
Sample output:
[ 31.450263] VFS_WARN_ON_INODE("crap") encountered for inode ffff9b10837a3240
fs sockfs mode 140777 opflags c flags 0 state 100
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
---
fs/inode.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/fs/inode.c b/fs/inode.c
index 833de5457a06..e8c712211822 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -2935,10 +2935,18 @@ EXPORT_SYMBOL(mode_strip_sgid);
*
* TODO: add a proper inode dumping routine, this is a stub to get debug off the
* ground.
+ *
+ * TODO: handle getting to fs type with get_kernel_nofault()?
+ * See dump_mapping() above.
*/
void dump_inode(struct inode *inode, const char *reason)
{
- pr_warn("%s encountered for inode %px", reason, inode);
+ struct super_block *sb = inode->i_sb;
+
+ pr_warn("%s encountered for inode %px\n"
+ "fs %s mode %ho opflags %hx flags %u state %x\n",
+ reason, inode, sb->s_type->name, inode->i_mode, inode->i_opflags,
+ inode->i_flags, inode->i_state);
}
EXPORT_SYMBOL(dump_inode);
--
2.43.0
next prev parent reply other threads:[~2025-09-11 4:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 4:55 [RFC PATCH v3 0/4] ->i_state accessors Mateusz Guzik
2025-09-11 4:55 ` Mateusz Guzik [this message]
2025-09-11 5:54 ` [PATCH v3 1/4] fs: expand dump_inode() Dave Chinner
2025-09-11 4:55 ` [PATCH v3 2/4] fs: hide ->i_state handling behind accessors Mateusz Guzik
2025-09-11 6:52 ` Dave Chinner
2025-09-11 9:00 ` Mateusz Guzik
2025-09-15 12:41 ` Christian Brauner
2025-09-15 13:27 ` Mateusz Guzik
2025-09-15 13:41 ` Christian Brauner
2025-09-15 13:48 ` Mateusz Guzik
2025-09-15 14:16 ` Christian Brauner
2025-09-11 4:55 ` [PATCH v3 3/4] convert all filesystems to use the new ->i_state accessors Mateusz Guzik
2025-09-11 4:55 ` [PATCH v3 4/4] type switch Mateusz Guzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250911045557.1552002-2-mjguzik@gmail.com \
--to=mjguzik@gmail.com \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ocfs2-devel@lists.linux.dev \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.