Re: [PATCH] mfd: tps6594: Explicitly include bitfield.h

[Lee Jones <lee@kernel.org>]

On Thu, 11 Sep 2025, Lee Jones wrote:

> On Fri, 05 Sep 2025, Michael Walle wrote:
> 
> > Hi Nathan,
> > 
> > On Fri Sep 5, 2025 at 3:26 AM CEST, Nathan Chancellor wrote:
> > > After a recent change that started using FIELD_GET() in tps6594-core.c,
> > > there is an error when bitfield.h is not implicitly included, such as
> > > when building allmodconfig for ARCH=hexagon:
> > 
> > Thanks! I was already in a discussion with Lee about how to handle
> > that.
> > 
> > >   drivers/mfd/tps6594-core.c:767:7: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> > >     767 |                 if (FIELD_GET(TPS65224_MASK_EN_PB_VSENSE_CONFIG, pwr_on) == TPS65224_EN_SEL_PB ||
> > >         |                     ^
> > >
> > > Explicitly include bitfield.h to resolve the errors.
> > >
> > > Fixes: d766ca01c208 ("mfd: tps6594: Add power button functionality")
> > > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> > 
> > In any case:
> > Reviewed-by: Michael Walle <mwalle@kernel.org>
> > 
> > Also,
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202509032356.LGa5hygM-lkp@intel.com/
> > 
> > > ---
> > > It looks like this should go into ib-mfd-input-6.18.
> > 
> > Yeah probably. Lee, is that possible?
> 
> Hold my beer!

https://lore.kernel.org/all/20250911151400.GR9224@google.com/

-- 
Lee Jones [李琼斯]